Git Product home page Git Product logo

Comments (12)

nukeop avatar nukeop commented on June 27, 2024

Can you tell me which artist causes this?
I noticed there are some gaps in the data I'm getting from Discogs, might have to switch to a different provider.

from nuclear.

ItsMeAtd avatar ItsMeAtd commented on June 27, 2024

The bug appears mainly when I try to play K-pop artists ( GOT7 / Twice / Red Velvet / EXID) I did manage to play their songs if I searched for the albums though

from nuclear.

nukeop avatar nukeop commented on June 27, 2024

I'll look into it. Some links are incorrect and point to nonexistent pages.

from nuclear.

NightMachinery avatar NightMachinery commented on June 27, 2024

I get the white screen at startup! :(

from nuclear.

nukeop avatar nukeop commented on June 27, 2024

Which version and what system?

from nuclear.

NightMachinery avatar NightMachinery commented on June 27, 2024

from nuclear.

nukeop avatar nukeop commented on June 27, 2024

I'll try to build newer binaries today (0.4.3), and let you know when they're ready.

from nuclear.

NightMachinery avatar NightMachinery commented on June 27, 2024

from nuclear.

pqrth avatar pqrth commented on June 27, 2024

@nukeop I tried nuclear-0.4.2.dmg and nuclear-0.4.0.dmg on macOS 10.13.5, but the app window is completely white as @NightMachinary shared:

image

from nuclear.

nukeop avatar nukeop commented on June 27, 2024

Hm, the problem seems to be that youtube and other services change their APIs often, and when that happens, previous versions get broken. I'll try to figure out if that's what happened here and update relevant packages and release 0.4.3 soon...

Also there's a problem with broken data on Discogs (e.g. links to non-existing albums), which might force me eventually to use Musicbrainz.

On another note, clearly a log file is needed so we can figure out what's going on when you get a blank screen. And probably better response to errors.

from nuclear.

pqrth avatar pqrth commented on June 27, 2024

Thanks a ton for the fix @nukeop. I built the master branch at commit 2ccc96e for macOS 10.13.6, and I can confirm that this issue is fixed.

Now, my npm install had failed due to No package 'dbus-1' found. So instead of removing optional dependency as suggested in the README.md, I installed the package d-bus via Homebrew (brew install d-bus) and then the missing package was found.

@nukeop Do you think these instructions would be helpful in the README? If so, I can create a pull request to add them.

from nuclear.

nukeop avatar nukeop commented on June 27, 2024

dbus is a Linux subsystem and as such is specified as an optional dependency. While it probably can be installed on Macs, I doubt that it'll do anything useful. On Linux, it's used for communicating with system widgets that can control the player.

Since you're saying that installation fails, this must mean that specifying it as an optional dependency is not enough (there should be a warning, but it should succeed nonetheless). In fact, there are two sets of different electron server files specifically for this reason (considering that dbus will not be present by default on MacOS and Windows).

If you want, you can add the instructions as a temporary workaround until we can figure out how to skip it completely.

from nuclear.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.