Comments (5)
This can be implemented with these events: https://www.electronjs.org/docs/latest/api/browser-window#event-app-command-windows-linux
from nuclear.
Hello i'm a learning dev and this implementation seems interesting, for adding purpose, i would like to know in what file this implementation would need to be in ?
from nuclear.
Somewhere in the main
package. For example, we handle many different events here: https://github.com/nukeop/nuclear/blob/master/packages/main/src/main.ts
However, since it requires handling different events per platform, it may also be a part of platform-specific services, which can be found here as @linux
, @mac
and @windows
: https://github.com/nukeop/nuclear/tree/master/packages/main/src/services
from nuclear.
I did work on this but was a little too slow, so i tried to adapt the part from the "if" into "switch" from the PR as nuki-chan said. I don't know if i did thing correctly or if this was necessary, i do apologies if this is not. The PR is #1567.
from nuclear.
Hm, I'd like to merge both of your PRs to acknowledge your contributions. And in fact both are necessary, because yours doesn't include @hollow-owl 's code. If I merge his first, then your PR will cause a merge conflict. You could try pulling changes from his fork first, then both your commits will be included, and merging your PR will effectively merge both PRs.
from nuclear.
Related Issues (20)
- Empty Playlists HOT 1
- Play counts not aligned HOT 1
- Add all tracks in the queue to an existing playlist HOT 7
- Playlist dialog title not translated (english only) HOT 2
- Cancelling importing a json file in playlist screen crashes the app
- Untranslated string HOT 1
- More untranslated strings HOT 1
- Miniplayer bugged controls HOT 3
- Global next/previous track shortcuts HOT 4
- Inaccurate tracks HOT 1
- Lyrics scroll back to the top on new song HOT 4
- Playlist net request issues HOT 1
- loading time is slow HOT 1
- App can't run after built ,the reason is scanner used the build machine's path HOT 4
- incorrect music downloads HOT 2
- I need the Nuclear Music Android app Please. HOT 5
- Sync playlist with youtube HOT 2
- Uncontrolled middle click behavior. HOT 4
- arm64 version HOT 3
- npm install fails on Windows for latest nodejs versions HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nuclear.