Window icons for pywebview are not displayed correctly about nuitka HOT 5 OPEN

I think I know what's causing the problem.

from nuitka.

pywebview uses sys.executable to get the file path of the current program and use the resource icon of that file, but after compiling in nuitka, what you get through sys.executable is the path of the python interpreter, e.g. C:\Users\ADMINI~1\AppData\ Local\Temp\ONEFIL~1\python.exe, I modified the pywebview window creation code and I have solved the problem!

• fix
  icon_handle = windll.shell32.ExtractIconW(handle, sys.executable, 0)
icon_handle = windll.shell32.ExtractIconW(handle, sys.argv[0], 0)
  Maybe it should be tested to see if it's working in a nuitka environment

Has compatibility been considered for this issue, please?

from nuitka.

We try and avoid fork bombs this way, however, however, given your patch, we can make sure to automatically apply it. I do not dare to wrap the windll, but we can make the source change with our anti-bloat engine no problem.

Can you tell me what module name this is in, then it will be good to go.

from nuitka.

We try and avoid fork bombs this way, however, however, given your patch, we can make sure to automatically apply it. I do not dare to wrap the windll, but we can make the source change with our anti-bloat engine no problem.

Can you tell me what module name this is in, then it will be good to go.

\site-packages\webview\platforms\winforms.py On line 203

# Application icon
handle = kernel32.GetModuleHandleW(None)
# icon_handle = windll.shell32.ExtractIconW(handle, sys.executable, 0)
icon_handle = windll.shell32.ExtractIconW(handle, sys.argv[0], 0)

This seems to be just a misunderstanding between Nuitka and pywebview.
XD

from nuitka.

Your patch is in line with the underlying reason of https://nuitka.net/user-documentation/common-issue-solutions.html#onefile-finding-files

I will add it now and you please let me know if it works for you.

Thanks for your report, this is fixed on the factory branch, which is a development version under rapid development. You can try it out by going here: https://nuitka.net/doc/factory.html

Feedback on whether this is working is very welcome. Please do not share plans to do it; only confirm or deny that it is working.

from nuitka.