Git Product home page Git Product logo

Comments (8)

kayhayen avatar kayhayen commented on September 26, 2024 1

So I merged your PR, and will put it on my factory branch, I don't think I really want to make this part of a relatively late hotfix, since it risks breaking existing setups. I tried Python 2.7 and 3.10 where Python is a symlink and it continued to work, that is something I care about. Moving it out to a separate function is bound to make the code maybe more readable.

from nuitka.

kayhayen avatar kayhayen commented on September 26, 2024 1

Part of the current pre-release.

from nuitka.

kayhayen avatar kayhayen commented on September 26, 2024

Screenshots and no version information, I am sure you can do better, and I have indeed changed something there recently for #2732 and this code for resolving symlinks is needed, because many tools don't work with non-real paths. I think the issue solution there was to indeed avoid resolve something different.

from nuitka.

kayhayen avatar kayhayen commented on September 26, 2024

I fixed getFilenameRealPath to undo the damage in case drive letters get lost, but it may not be general enough to cover these mounts in the middle of things. You are more than welcome to make it walk the path up if it should be necessary.

from nuitka.

belonesox avatar belonesox commented on September 26, 2024

Sorry, I liked to make bug reports completely reproduceable,
but VMs in Windows world are strange, there is no reliable way to make it reproduceable by some unified way (VirtualBox, Hyper-V, Windows Sandbox):

So, I would like to know, what virtualization have you on your windows stand, to make reproduceable examples with vagrant (for example).

I catch the issue sometimes ago, make quick fix "works for me", and was testing on my different projects during several weeks. So, I miss the #2732 and unfortunately, I dont see linked commits that should fix this issue for checking.

I tried to check latest pre-release commit ea9093d

and the issue still persists somehow:

nuitka-crash-report.zip

What tools needed real UNC path here? Why just not

...
            newpath = path
            if not result.startswith('UNC'):
                newpath = os.path.join(
                    os.path.dirname(path), result.rstrip("\r\n")
                )
            _real_path_windows_cache[path] = newpath
...

from nuitka.

kayhayen avatar kayhayen commented on September 26, 2024

The commit history of the nuitka.utils.FileOperations.py has it. Due to rebasing for perfect git bisection, I don't use commit hashes as much as others do.

That change handles top level, but can surely be extended.

Like I said, many tools cannot work with symlinks, and need short paths in 8.3 style to work reliably. This includes tools from big companies. The realpath does more than it's supposed to do there, but it cannot do only one thing. Reverting it to drive letter paths, was easy for me. I imagine you can make it more general.

from nuitka.

kayhayen avatar kayhayen commented on September 26, 2024

Thanks for your PRs, these are all super useful, keep em coming :)

from nuitka.

kayhayen avatar kayhayen commented on September 26, 2024

Part of the 2.2 release I just made.

from nuitka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.