Long Type integration and Unicode Type Integration to support Python 3.12 about nuitka HOT 5 CLOSED

I think "negation" of longs needs to be its own helper function, surely it works differently. This is 3.11 code

static PyObject *
long_neg(PyLongObject *v)
{
    PyLongObject *z;
    if (IS_MEDIUM_VALUE(v))
        return _PyLong_FromSTwoDigits(-medium_value(v));
    z = (PyLongObject *)_PyLong_Copy(v);
    if (z != NULL)
        Py_SET_SIZE(z, -(Py_SIZE(v)));
    return (PyObject *)z;
}

As you can see, they used to the negation (of an object, they are shortcutting for small numbers) with Py_SIZE negation, playing a dirty trick anymore. If you check out the same in 3.12, you can get a good idea of how it's now.

static PyObject *
long_neg(PyLongObject *v)
{
    PyLongObject *z;
    if (_PyLong_IsCompact(v))
        return _PyLong_FromSTwoDigits(-medium_value(v));
    z = (PyLongObject *)_PyLong_Copy(v);
    if (z != NULL)
        _PyLong_FlipSign(z);
    return (PyObject *)z;
}

So, I guess, you would have to add a _NuitkaLong_FlipSign with the code of 3.11 and 3.12 behind #if

from nuitka.

#if PYTHON_VERSION < 0x3c0
#define _NuitkaLong_FlipSign(x) Py_SET_SIZE(x, -(Py_SIZE(x)));
#else
#define _NuitkaLong_FlipSign _PyLong_FlipSign
#endif

This should be it. Find all the places that do this, and call the new "function" from there. If done correctly, you see no change for Python3.11, and for Python3.12 one C compile error will be gone. The proper spot could be nuitka/build/include/nuitka/helper/ints.h although maybe I forgot and there is a better one.

Then rinse and repeat. For everything done there, we have a Python longobject code that we need to make portable across versions essentially.

from nuitka.

The 0x3c0 is 3.12

from nuitka.

I did this and it's currently on factory branch.

from nuitka.

Bummer, sorry didn't know you were going to move this fast on this issue. Thanks anyway

from nuitka.