Git Product home page Git Product logo

Comments (2)

neighthan avatar neighthan commented on June 4, 2024 1

This happens because the reset zoom button is in a nav element, but I remove nav elements from the html in the IPython magic (I found it nicer without the nav bar when it's already embedding in a notebook). Then from icicle.js, it tries to access the button, but there's nothing to find.

It's easy to remove just the nav bar and leave the reset zoom button or even leave the button and the nav bar, but when I tested using the reset zoom button in a notebook, I just get a few hundred errors in the console like Error: <rect> attribute y: Expected length, "NaN". I don't mind the lack of this button right now, so I probably won't debug why it doesn't work in a jupyter notebook.

In my local version, my "fix" is to just keep the reset zoom button removed and also remove the reference to it from icicle.js (only when in-lining icicle.js into the HTML to put in the notebook; I don't edit the actual .js file). I could submit a PR for this if desired, since it's probably nicer to have the notebook version working without a reset zoom button rather than not working at all. If you want to hold out for a real fix that makes the button work, though, that's fine.

from tuna.

nschloe avatar nschloe commented on June 4, 2024

No idea why this should be happening, really. I'll be more than happy to review PRs fixing this!

from tuna.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.