Git Product home page Git Product logo

Comments (2)

kyr-pol avatar kyr-pol commented on August 28, 2024

I don't see how this is necessary. I guess the original authors found it helpful empirically, maybe for numerical stability etc. Since there might be other design choices like this one, that look arbitrary, I think could do either of two things:

  1. Keep them in our code too, to be consistent with the original application, and assuming that these were found to be beneficial to the algorithm's performance
  2. Not add them if we don't see the benefit, but keep track of them somehow, so in the case we end up having numerical or other issues on a future scenario, we can try adding things from the list.

I think 2 is reasonable, in a sense we are already doing it by not adding any trigonometric augmentation of dimensions that are angles for example, and it keeps our code cleaner until it's necessary to complicate things further.

from pilco.

nrontsis avatar nrontsis commented on August 28, 2024

Let's do this, at least for the sake for compatibility.

from pilco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.