Git Product home page Git Product logo

Comments (7)

ilg-ul avatar ilg-ul commented on July 3, 2024

To rule out a bad local configuration, I also tried on a separate Ubuntu VM and the result is the same, but git asked for credentials:

$ pacote resolve npm/cli
The authenticity of host 'github.com (140.82.118.4)' can't be established.
RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
Are you sure you want to continue connecting (yes/no)? yes
{ Error: failed '/usr/bin/git ls-remote git+ssh://[email protected]/npm/cli.git'
...

from pacote.

ilg-ul avatar ilg-ul commented on July 3, 2024

I'm very curious why npm can install packages from GitHub. Is it because it is using an older pacote (^9.5.9)?

from pacote.

ilg-ul avatar ilg-ul commented on July 3, 2024

I confirm that after reverting to 9.5.9 I can access GitHub repos using org/name, as expected.

So it must be an issue with 10.x. The next question would be why the tests did not catch it...

from pacote.

isaacs avatar isaacs commented on July 3, 2024

The issue is that it's preferring git+ssh over git+https for all hosted repos.

Fix coming shortly :)

from pacote.

isaacs avatar isaacs commented on July 3, 2024

I noticed this when my tests in npm/arborist were buzzing my phone for a 2FA authorization to use my SSH keys :)

SSH is better for private repos, since it's more straightforward for doing headless authentication with a key and doesn't require putting a basic auth in the url, but obviously not as good for public repos, which is the majority use case. Pacote 9 tries https, then falls back to ssh, which is what v10.1.6 does now as well.

from pacote.

ilg-ul avatar ilg-ul commented on July 3, 2024

Since I'm not familiar with the implementation details, can you confirm that the behaviour now is fully similar to that of 9.x?

I'm a bit concerned about 'Resolved url is still reported as the git+ssh url, for consistency.' Was it the same in 9.x?

from pacote.

isaacs avatar isaacs commented on July 3, 2024

The resolved url always being saved as ssh is new. (In v9 it was less deterministic, varying if the original url was ssh or https.) But the fetch behavior is the same as v9 now, yes.

from pacote.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.