setting maxRecordSize to 0 does not result in a empty records array about npmlog HOT 4 CLOSED

hi, I can't reproduce this.
When I maxRecordSize to 0, it will be the same number of log entries.
This means, this is correct, right ?

from npmlog.

https://github.com/npm/npmlog/blame/c027c276f6f7e6c8d808767b0d611555e3ef5f61/log.js#L206

It's doing a slice(-0) which doesn't do anything.

from npmlog.

yup, I'm understanding like this:
if maxRecordSize is 0, then do nothing, keep the array (record) growing.
( since we don't care about the max size)
Which seems correct.

But, maybe the docs are not clear and needs to be improved, because it tells nothing about the maxRecord to be zero. https://github.com/npm/npmlog#logmaxrecordsize
In this case ^ 👍.

Or I did not get the point at all.

from npmlog.

Closing due to age. Feel free to submit a readme update if you feel this still need clarifying

from npmlog.