Comments (17)
jainpawan21
commented on June 10, 2024
1
@jainpawan21 can I take this issue? Please assign it to me
@Ujjwal55 Assigning this to you 🙂
from novu.
linear
commented on June 10, 2024
NV-3311 [NV-3300] most recent change should be on the top in changes page
from novu.
github-actions
commented on June 10, 2024
Hi, I'm Jarvis 🤖%0A%0AI'm a bot built to help you with your contribution to Novu. %0AI will add instructions and guides on how to run the subset of the Novu platform associated to this issue and make your first contribution.%0A%0AThis issue was tagged as related to @novu/api and the related code is located at the apps/api folder, here is how I can help you:%0A%0A
%0A
%0A%0AFirst time contributing to Novu?
%0A%0A If that's the first time you want to contribute to Novu here are a few simple steps to get you started:%0A 1. Fork the repository and clone your fork to your local machine.%0A 2. Install the dependencies usingnpm run setup:project.%0A 3. Create a new branch with the number of the issue, for example: 1454-fix-something-cool and start contributing based on the Contributing Guide or the short guide in the section below.%0A 4. Create a Pull request and follow the template of creation %0A%0A Run and test
%0A%0A ### Run API in watch mode%0A The easiest way to start the API is to run
Run and test @novu/api locally
%0A%0A ### Run API in watch mode%0A The easiest way to start the API is to run npm run start:api from the root of the repository%0A%0A ### Run API integration tests%0A To validate your changes or simply to run the e2e tests run npm run start:e2e:api. All the e2e tests have the .e2e.ts suffix and usually are located near the controller files of each module.%0Afrom novu.
Ujjwal55
commented on June 10, 2024
@jainpawan21 can I take this issue? Please assign it to me
from novu.
sudhanshugautam2911
commented on June 10, 2024
@jainpawan21 I would like to work on this issue. Please assign me
from novu.
m-Chetan
commented on June 10, 2024
Hello @jainpawan21 I have already worked on this issue. Could you please merge it if everything is fine?
from novu.
Ujjwal55
commented on June 10, 2024
@jainpawan21 can I take this issue? Please assign it to me
@Ujjwal55 Assigning this to you 🙂
Please review this pr #5010 @jainpawan21
from novu.
mahendraHegde
commented on June 10, 2024
@Ujjwal55 @m-Chetan you both followed the same approach of sorting in mem in the UI, but i believe it should be done on /changes api side while querying DB.
@jainpawan21 correct me if i'm wrong.
from novu.
Ujjwal55
commented on June 10, 2024
@Ujjwal55 @m-Chetan you both followed the same approach of sorting in mem in the UI, but i believe it should be done on
/changesapi side while querying DB. @jainpawan21 correct me if i'm wrong.
Okk, I'll do it
from novu.
m-Chetan
commented on June 10, 2024
@mahendraHegde sure we can fetch it from DB in descending order from api side
from novu.
m-Chetan
commented on June 10, 2024
@jainpawan21 I have made changes in the PR to fetch the changes from api side while querying DB.
Could you please review if this is fine
from novu.
scopsy
commented on June 10, 2024
@Ujjwal55 are you still on it? Or shouldIassign @m-Chetan for this issue?
from novu.
Ujjwal55
commented on June 10, 2024
@mahendraHegde sure we can fetch it from DB in descending order from api side
@m-Chetan this issue has been assigned to me, so you can work on other open issues.
from novu.
Ujjwal55
commented on June 10, 2024
@Ujjwal55 are you still on it? Or shouldIassign @m-Chetan for this issue?
Yes I am working on this
from novu.
Ujjwal55
commented on June 10, 2024
@scopsy I have done the change, you can review it. But I wanted to ask one thing whenever I did any change to the change.repository.ts file, the server the change didn't reflected even if I empty the whole file but this was not the case with files inside app directory. Can you help why it maybe the issue?
from novu.
scopsy
commented on June 10, 2024
@Ujjwal55 dal is a separate package that you need to build. Have you run a build in its package folder?
from novu.
Ujjwal55
commented on June 10, 2024
@Ujjwal55 dal is a separate package that you need to build. Have you run a build in its package folder?
Not yet, now I know why it wasn't running
from novu.
Related Issues (20)
- 🐛 Bug Report: Error when copy/paste template code to email editor - Failed to extract variables HOT 5
- 🐛 Bug Report: Message content could not be generated HOT 4
- 🐛 Bug Report: Layouts not loaded on web admin client HOT 3
- 🐛 Bug Report: Message dropdown menu is hidden by below the notifications center header HOT 2
- 🐛Cannot find module react-scanner.config.js HOT 8
- 🚀 Feature: Specify data for each step using Expo provider HOT 2
- 🐛 Bug Report: Test HOT 1
- 🐛 Bug Report: step conditions not working with push webhook provider HOT 1
- TechTop HOT 1
- New organization onboarding through api (Getting api key of newly created organization) HOT 2
- * HOT 1
- 🐛 Bug Report: cannot trigger workflow with topic HOT 6
- 🐛 Bug Report: Angular ^17.0.0 - flushSync was called from inside a lifecycle method. React cannot flush when React is already rendering HOT 1
- 🚀 Feature: Allow specifying delivery preferences on the topic level HOT 1
- 📚 Docs Feedback: Faulty "to" description for event triggering HOT 1
- Update calendly link to Hubspot meeting HOT 2
- 🚀 Feature: SvelteKit Serve Function Addition HOT 2
- 🐛 Bug Report: LogDecorator mistakenly redacted function parameters when LoggingLevel = debug HOT 3
- 🐛 Bug Report: Icon layoutShift when scrolling HOT 1
- Returning 404 on API and worker link but no logs in error🐛 Bug Report: HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from novu.