Peer Segment Download Timeout about p2p-media-loader HOT 12 CLOSED

I've made some debug.

When the video freezed, I've checked the current downloading segments and found the peerId. And when I checked Peer's downloadingSegment value, I see that its not increasing. It must be a very slow connection or upload speed etc.

After I destroy that Peer, segment downloaded from http and video continued.

So I believe that p2pSegmentDownloadTimeout is not doing its job.

from p2p-media-loader.

p2pSegmentDownloadTimeout represents downloading timeout or connection timeout?

It is the connection timeout (i.e. timeout for the response from the remote peer that it is willing to send us the requested segment) and not the timeout of segment data download.

Documentation should be improved.

from p2p-media-loader.

I've write some code snipped to handle this downloading timeout situation. This 5 second interval is checking active downloading segments every time and if the downloaded byte value is not change for the next tick, it will cancel that segment download process.

var peerSegmentStats = [];
window.setInterval(function() {
	engine.loader.p2pManager.peers.forEach(function(peer) {
		if(peer.downloadingSegment !== null) {
			if(peerSegmentStats[peer.downloadingSegment.id] !== peer.downloadingSegment.bytesDownloaded)
				peerSegmentStats[peer.downloadingSegment.id] = peer.downloadingSegment.bytesDownloaded;
			else {
				console.log("cancelling", peer.downloadingSegment.id ,"request from", peer.id, (peer.downloadingSegment.bytesDownloaded/1024).toFixed(2), "/", (peer.downloadingSegment.size/1024).toFixed(2));
				delete peerSegmentStats[peer.downloadingSegment.id];
				engine.loader.p2pManager.peerSegmentRequests.delete(peer.downloadingSegment.id);
				peer.cancelSegmentRequest();
			}
	    }
	});
}, 1000*5)

engine.loader.on(p2pml.core.Events.SegmentLoaded, function (segment) {
    delete peerSegmentStats[segment.id];
});

from p2p-media-loader.

Yes, it can be done by adding and handling additional configuration parameters.

Currently, if a remote peer is slow and failed to deliver full segment in time, the P2P download will be aborted and HTTP download initiated.

requiredSegmentsPriority configuration parameter, that is also not very well documented, is responsible for this.

requiredSegmentsPriority | Integer | 1 | The maximum priority of the segments to be downloaded (if not available) as quickly as possible (i.e. via HTTP method)

By default next 2 segments after currently playing segment, if not already downloaded over P2P, will be forced to be downloaded over HTTP.

from p2p-media-loader.

Currently, if a remote peer is slow and failed to deliver full segment in time, the P2P download will be aborted and HTTP download initiated.

What do you mean by in time Is there an option to set this time?

What I need is something like this;

If a remote peer is slow and failed to deliver full segment in 5 seconds, the P2P download will be aborted and HTTP download initiated. And It's configuring like this;
peerFailAbortTime: 5000

In my case, all segments should be downloaded at least 5 seconds. I already make this happend with the code send you above but If there is a way to do this within the library, I would like to use that for integrity.

from p2p-media-loader.

By default with "requiredSegmentsPriority = 1" in time means that the segment you are downloading over P2P should not become of priority 0 or 1.

Priority 0 has the segment that goes next after currently playing one. Priority 1 has the segment next after segment with priority 0.

from p2p-media-loader.

I still didn't understand how am I going to limit the segment download time within X seconds. :(

from p2p-media-loader.

It is not possible. And I am not sure that it should be implemented.

But when player reaches that segment, Its just freezes and waiting the segment download finish.

Checking this now. It should not happen.

from p2p-media-loader.

But when player reaches that segment, Its just freezes and waiting the segment download finish.

I cannot reproduce it. If a segment is loading very slow over P2P, the download will be canceled and the segment will be downloaded over HTTP.

from p2p-media-loader.

You can try to increase requiredSegmentsPriority or segment duration. Probably not enough time to download slow P2P segments over HTTP.

from p2p-media-loader.

var peerSegmentStats = [];
window.setInterval(function() {
	engine.loader.p2pManager.peers.forEach(function(peer) {
		if(peer.downloadingSegment !== null) {
			if(peerSegmentStats[peer.downloadingSegment.id] !== peer.downloadingSegment.bytesDownloaded)
				peerSegmentStats[peer.downloadingSegment.id] = peer.downloadingSegment.bytesDownloaded;
			else {
				console.log("cancelling", peer.downloadingSegment.id ,"request from", peer.id, (peer.downloadingSegment.bytesDownloaded/1024).toFixed(2), "/", (peer.downloadingSegment.size/1024).toFixed(2));
				delete peerSegmentStats[peer.downloadingSegment.id];
				engine.loader.p2pManager.peerSegmentRequests.delete(peer.downloadingSegment.id);
				peer.cancelSegmentRequest();
			}
	    }
	});
}, 1000*5)

engine.loader.on(p2pml.core.Events.SegmentLoaded, function (segment) {
    delete peerSegmentStats[segment.id];
});

This is working fine so we can close this case.

from p2p-media-loader.

var engine = new p2pml.hlsjs.Engine({
  loader: {
    cachedSegmentExpiration: 1000 * 60 * 60 * 2,
    cachedSegmentsCount: 800,
    simultaneousP2PDownloads: 15,
    bufferedSegmentsCount: 30,
    p2pSegmentDownloadTimeout: 5000
  }
});

With this configuration, I've managed to increase peer ratio from ~%20 to ~%50... There were no reports from users for now. So I'll try to increase these numbers a little bit if noone complain about crashes or etc.

from p2p-media-loader.