Looping if no connection to APN Server or host is unknown about java-apns HOT 2 CLOSED

I would suggest just dropping the while loop in the socket() method. The retry handling is implemented in the sendMessage method, so something like this:

private synchronized Socket socket() {
    if (reconnectPolicy.shouldReconnect()) {
        Utilities.close(socket);
        socket = null;
    }

    if (socket == null || socket.isClosed()) {
        try {
            socket = factory.createSocket(host, port);
            reconnectPolicy.reconnected();
            logger.debug("Made a new connection to APNS");
        } catch (IOException e) {
            throw new RuntimeException("Couldn't connect to APNS server", e);
        }
    }

    return socket;
}

would work fine I believe - I see no reason to have the while loop in the socket method. Throwing a RuntimeException from the socket method is probably not the best approuch as it will give a RuntimeException wrapped in another RuntimeException, however it is in line with the remaining code (see issue with wrapping RuntimeExceptions).

from java-apns.

Fixed in repo

from java-apns.