Add support to Archive (delete) a page about notion-sdk-net HOT 5 CLOSED

Do you need this implementation into your existing endpoints or into a new endpoint? If it is an existing endpoint, which endpoint needs to be modified? Is it UpdatePropertiesAsync?

from notion-sdk-net.

You can add new endpoint named UpdateAsync in IPagesClient. I'm thinking of deprecating the UpdatePropertiesAsync endpoints in future. We may introduce a separate endpoint which is dedicated to just Delete a page.

from notion-sdk-net.

Ok, So, I am sharing my idea of how we can do that from my understanding.

1. First of all, we have to keep in mind that a user can un-archive or restore a page at any time, so we have to make it soft delete.
2. To make it soft delete, when a user makes a delete request like DeletePage(pageId, true) we just update the value of the archive property true or false
3. When a user wants to Retrieve a page at that time we only return a page whose archive property is true.

Is it make sense or not with your requirements, please give your valuable feedback

from notion-sdk-net.

I think we can just implement UpdateAsync endpoint for IPagesClient at the moment & add Deprecated attribute on UpdatePropertiesAsync endpoint.

This is not required but if need we can add ArchiveAsync and UnArchiveAsync but I'm not sure atm as Notion API is changing
and user can use UpdateAsync if they want to un-archive a page. but if it is not much of work for you then go ahead.

I did not understood your third page I don't think this would affect any other API.

from notion-sdk-net.

I just came across this issue as well while adding delete.

Koditkar, I think your approach is correct. Outside of properties, only the IsArchived flag is modifiable on a page.
Something like UpdateAsync( pageId, properties, archive ).
This is consistent with your nice generic interface pattern.

from notion-sdk-net.