Prefixing the value of `cwd` to the file of matched errors about atom-build HOT 7 CLOSED

I see. I think it really should match the file relative to the specified cwd. If cwd is not specified it should be relative the root directory of the project. Thanks for reporting!

from atom-build.

I have fixed this on master. Please test it and see if it works for you!

It will be included in the next release (v0.30.0).

Thanks for reporting this!

from atom-build.

Thanks for looking into this promptly.
I tried your change, and it almost works ... but not quite.

The problem is that it is not expanding variables that appear in the cwd field.

Specifically, my cwd field is set to "{FILE_ACTIVE_PATH}". So, your change causes the error jumping feature to go searching for {FILE_ACTIVE_PATH}/myfile.txt ... which is bad, of course.

Can you expand variables before pre-pending to the path?

Thanks!

from atom-build.

This change does the trick:
At build.js line 181:

    atom.workspace.open(this.replace(this.cmd.cwd) + path.sep + this.match[0].file, {

At build.js line 198:

 atom.workspace.open(this.replace(this.cmd.cwd) + path.sep + this.match[0].file, {

from atom-build.

That is true! Excellent catch. Do you want to make a PR for that change, or should I just change it?

from atom-build.

Please change yourself... Thanks!

Sent from my Windows Phone

From: Alexander Olssonmailto:[email protected]
Sent: ‎4/‎30/‎2015 10:01
To: noseglid/atom-buildmailto:[email protected]
Cc: nikswamymailto:[email protected]
Subject: Re: [atom-build] Prefixing the value of cwd to the file of matched errors (#63)

That is true! Excellent catch. Do you want to make a PR for that change, or should I just change it?

Reply to this email directly or view it on GitHub:
#63 (comment)

from atom-build.

This has been fixed on master. Would you mind testing it out?

from atom-build.