cross-reference among source, source_id, model_id about noresm2cmor HOT 7 CLOSED

Sounds reasonable. Though, it would be good if you could perform a quick test before pushing the change. Thanks.

from noresm2cmor.

Yes, it tested it and it works, if I put values in CMIP6_CV.json to 'source', without warning.

I will commit the change. It will not affect previous cmorization namelist.

However, if I change the

institution   = 'NorESM Climate modeling Consortium consisting of CICERO (Center for International Climate and Environmental Research, Oslo 0349), MET-Norway (Norwegian Meteorological Institute, Oslo 0313), NERSC (Nansen Environmental and Remote Sensing Center, Bergen 5006), NILU (Norwegian Institute for Air Research, Kjeller 2027), UiB (University of Bergen, Bergen 5007), UiO (University of Oslo, Oslo 0313) and UNI (Uni Research, Bergen 5008), Norway. Mailing address: NCC, c/o MET-Norway, Henrik Mohns plass 1, Oslo 0313, Norway',

copied from the CMIP6_CV.json
It will have warning like:
! Warning: Your input attribute institution "NorESM Climate modeling Consortium consisting of CICERO (Center for International Climate and Environmental Research, Oslo 0349), MET-Norway (Norwegian Meteorological Institute, Oslo 0313), NERSC (Nansen Environmental and Remote Sensing Center, Bergen 5006), NILU (Norwegian Institute for Air Research, Kjeller 2027), UiB (University of Bergen, Bergen 5007), UiO (University of Oslo, Oslo 0313) and UNI (Uni Research, Bergen 5008), Norway. Mailing address: NCC, c/o MET-Norway, Henrik Mohns plass 1," will be replaced with
! "NorESM Climate modeling Consortium consisting of CICERO (Center for International Climate and Environmental Research, Oslo 0349), MET-Norway (Norwegian Meteorological Institute, Oslo 0313), NERSC (Nansen Environmental and Remote Sensing Center, Bergen 5006), NILU (Norwegian Institute for Air Research, Kjeller 2027), UiB (University of Bergen, Bergen 5007), UiO (University of Oslo, Oslo 0313) and UNI (Uni Research, Bergen 5008), Norway. Mailing add

(Note there are truncation of string in the end, but that should be related to the write(,) statement).

I guess the the institution have quite some special characters, and fortran does not value them as the same string, anyhow (I don't know why).

from noresm2cmor.

The string is exactly of length 500 characters at ",". So if you increase the maximum length from 500 to e.g. 1024 then it should work.

from noresm2cmor.

The removal of "source" from the model input namelist caused all my active CMOR-ization processes to crash after re-compilation since I did not modify all input namelists. Also, it will break CMIP5 cmor-ization backward compatibility. Therefore it would be good if the source, source1 lines could be added back in m_namelists.F. Thanks.

from noresm2cmor.

I did not touch source, but only set source_id with model_id instead of using source1.

Please pull again to my last push, and then you can change as it is backward compatible.

commits: eb2f81b and 1e70e22

from noresm2cmor.

Sorry, I was mistaken then. The reason for the crash must be of different nature.

from noresm2cmor.

It was this change that caused my CMOR-ization to crash NorwegianClimateCentre@943dcc4#diff-549f710a48116db7c44533ecedb5a864

I am going to move the source_type specification for NorCPM1 from model to experiment namelist.

In the future, if any changes are made to the source code that affect the namelist read then I strongly suggest that all committed namelist files are updated as well. It is no good to have broken namelists in the repository. If someone at a later stage tries to make them work then it will take time and effort to find out why the namelists don't work in the first place.

from noresm2cmor.