Git Product home page Git Product logo

Comments (9)

tjiputra avatar tjiputra commented on September 15, 2024

I also think it's best to go with option (b). Scientifically, it'd be more logical when comparing different simulations or when merging code versions.

from blom.

JorgSchwinger avatar JorgSchwinger commented on September 15, 2024

With the new coordinates the upper 2 layers of the model are quite thin, i.e. the volume for N-fixation is small und thus PP will be reduced somewhat. So in this regard, the change belongs to the new vertical coordinates.

from blom.

TomasTorsvik avatar TomasTorsvik commented on September 15, 2024

If PR #154 is accepted, the N-fixation should take place over the entire mixed layer depth (defined by the kOBL index). This will hopefully solve the issue with the 2 top layers being very thin, at least for the first implementation. It has the advantage that the code change should be "minimal", in the sense that the vertical coordinate change will not coincide with another conceptual code change.

from blom.

tjiputra avatar tjiputra commented on September 15, 2024

I thought the idea is to limit N2 fixation to the euphotic zone, and not the whole MLD. According to this, N2-fixation requires lights: https://www.sciencedirect.com/science/article/pii/S1385110104000930, though probably during deep MLD, temperature limitation come into effect.

from blom.

TomasTorsvik avatar TomasTorsvik commented on September 15, 2024

I agree that we should have N2 fixation in the euphotic zone, but in the first instance I would like to have a version that is mostly backwards compatible with CMIP6 simulations, so that we can evaluate "pure" coordinate changes. Perhaps this will only be a short-lived intermediate step, but I think it is safer to do it one step at a time.

from blom.

jmaerz avatar jmaerz commented on September 15, 2024

Maybe it's worth thinking about another 2D field similar to kmle in #154 to indicate the depth of the euphotic zone? - so making it possible to differentiate between MLD and euphotic zone depth - then one has the possibility to switch between the two cases during run time for the cyanobacteria by initializing the field either via i) the current MLD or ii) a constant value (or iii) potentially even a value based on light intensity).

from blom.

TomasTorsvik avatar TomasTorsvik commented on September 15, 2024

The depth of the euphotic zone is currently set to a fixed value dp_ez = 100.0, but the k-index kwrbioz corresponding to this depth is already a 2D field. It should be fairly straight forward to extend the set_vgrid routine to change the calculation for kwrbioz. I suppose it could have a significant effect in ocprod if we decide to change the definition of this field.

from blom.

jmaerz avatar jmaerz commented on September 15, 2024

Hi Tomas, I wouldn't touch ocprod here (since, as you pointed out, setting kwrbioz differently would change a lot in ocprod) and was more thinking about an analogue of kwrbioz for the cyanobacteria only (e.g. kwrcyaz or similar) - which you then can use as described earlier.

from blom.

JorgSchwinger avatar JorgSchwinger commented on September 15, 2024

As a starting point, we could just use kwrbioz as it is, also for the nitrogen fixation? If the process needs enough light(?), then this would be more justifiable than using mld. But since this would break backwards-compatibility we should probably introduce this at a well defined point...

from blom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.