TAPA mem leak during periodic Stream Close-Open about meridio HOT 2 CLOSED

There seems to be a goroutine leak in interfacename.InterfaceNameChache:

• ReleaseTrigger() usage is faulty: started goroutine is not cancelled if the release gets aborted
• There's also no point calling releaseTrigger() a second time in pendingRelease() if the inteface name couldn't be cancelled immediately in Release().

This problem might arise, if NSM is trying to heal a TAPA connection. The longer it takes to connect with a Proxy, the more goroutines are created. If I'm not mistaken, these goroutines should eventually exit (after 10 minutes or so), but they increase memory usage till then.

Yet, there's another independent issue leading to increased memory usage when Conduit connection is periodically closed and re-opened as described in the bug description.

from meridio.

Another leak looks to be related to the recurring connectNSPService() call that spams workloadapi.NewX509Source() through credentials.GetClient(), while the new source will get never released. The meridio/pkg/security/credentials pkg is basically faulty and requires redesign.

Note:
The Trench is cleaned-up upon Stream close when all Conduits are disconnected in a Trench. Then will get re-created on a subsequent Stream open.

TODO: Would be worth tracking down and checking all occurrences of workloadapi.NewX509Source() for possible resource leakage.

from meridio.