Comments (2)
Hi, I'd like to take a stab at this. Before starting I had a few questions
Which one of the two is preferable here?
const { isOpen, open, close, toggle: setOpen } = useDisclosure(false); close();
const disclosureHook = useDisclosure(false); disclosureHook.toggle();
Which one of the two is preferable here? (I assume close since it doesn't add an extra type check) In case of a setState(false) -> If I have understood it correctly,
toggle(false)
andclose()
will do essentially the same thing.
Hey, below version is preferable (use toggle
only if necessary, prefer close/open).
const { isOpen, close, open, toggle } = useDisclosure();
from gnui.
Hi, I'd like to take a stab at this. Before starting I had a few questions
Which one of the two is preferable here?
const { isOpen, open, close, toggle: setOpen } = useDisclosure(false);
close();
const disclosureHook = useDisclosure(false);
disclosureHook.toggle();
Which one of the two is preferable here? (I assume close since it doesn't add an extra type check)
In case of a setState(false) -> If I have understood it correctly, toggle(false)
and close()
will do essentially the same thing.
from gnui.
Related Issues (20)
- Add types for Accordion component
- Add types for Dropdown component
- Fix eslint warnings inside Table component
- Unify React imports and usage HOT 1
- Add missing types for various components HOT 1
- Storybook Preview block deprecated
- Storybook showRoots option location deprecated
- Storybook Input example throwing React error
- Storybook Switch example throwing React error
- Popover does not change visibility when clicking on icons
- Improve Prop types for Button Component HOT 1
- Replace react-awesome-styled-grid
- [Tests] Button
- [Tests] Dropdown
- [Tests] Modal
- [Tests] Tabs
- [Tests] TimeRangePicker
- [Tests] Tooltip HOT 1
- Dependency Dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gnui.