[Performance] NopResourceDisplayNameAttribute uses async methods synchronously - which leads to threadpool starvation in high traffic about nopcommerce HOT 3 CLOSED

Closed by b4f46d7

from nopcommerce.

@skoshelev I have just checked the commit and I see it's still using localization service call synchronously from NopResourceDisplayNameAttribute, I am not sure if that being used or not but if it's still there, the threadpool issue will not get fixed

//get locale resource value
_resourceValue = EngineContext.Current.Resolve().GetResourceAsync(ResourceKey).Result;

from nopcommerce.

@kiranbhadani That's right, the call remains inside the attribute for now, in case the attribute is used somewhere else outside the tag helper (for example, in third-party plugins), but in our code we removed all calls to this property

from nopcommerce.