Comments (9)
Could you create a minimal scenario where the bug can be reproduced?
(Or maybe a shell script that creates such a scenario.)
from git-gutter-plus.
Here's the script to create the two repos:
https://gist.github.com/dhaley/9692370
then:
/Applications/Emacs.app/Contents/MacOS/Emacs -Q &
(add-to-list 'load-path "/.emacs.d/site-lisp/git-gutter-plus")/.emacs.d/site-lisp/git-gutter-fringe-plus")
(add-to-list 'load-path "
(add-to-list 'load-path "/.emacs.d/site-lisp/git-modes")/.emacs.d/site-lisp/fringe-helper")
(add-to-list 'load-path "
(require 'git-gutter+)
(require 'git-commit-mode)
(require 'fringe-helper)
(require 'git-gutter-fringe+)
(global-git-gutter+-mode t)
M-x toggle-debug-on-error
(find-file "/tmp/repo2/cu.aliases.drushrc.php")
Then make changes to cu.aliases.drushrc.php and a save should trigger the backtrace.
Also all libraries mentioned are the latest HEAD from github.
from git-gutter-plus.
For now, I've disabled git-gutter+ on symlinked files.
Transparently forwarding all git-gutter+ operations to the linked file would require respecting the foreign file path and directory in all git calls and passing them to all (temp) buffers created by git-gutter+ that might depend on it. I'd like to avoid all the complexities involved.
To all users:
Would such a link forwarding feature be a huge help? Then please let me know and I'll give it another thought.
Another possible solution: An option to automatically open the original file when global-git-gutter+-mode
encounters a symlinked file. Would that be acceptable?
from git-gutter-plus.
To all users:
Would such a link forwarding feature be a huge help? Then please let me know and I'll give it another thought.
Count me in. My life is full of configuration files that are checked into git and that live in /etc only by virtue of a symbolic link.
from git-gutter-plus.
Hi,
i think opening the original would be the best choice.
I've recently switched to spacemacs with has some git-gutter as well, and it asks when it finds a symbolic link..
from git-gutter-plus.
it asks when it finds a symbolic link
Could you check where this is implemented?
Searching the spacemacs
and the original emacs-git-gutter
repos for symlink
or truename
gave no relevant hits.
from git-gutter-plus.
It appears to be what is mentioned here: http://stackoverflow.com/questions/15390178/emacs-and-symbolic-links which seems to be some standard emacs configuration: https://www.gnu.org/software/emacs/manual/html_node/emacs/General-VC-Options.html
Atleast in spacemacs i have not seen any problems with symlinks, but i am not sure if this is truely related to the git-gutter+ problem (as far as i can see, spacemacs uses plain git-gutter).
from git-gutter-plus.
Thanks!
So this is a feature of vc.el
. The link resolution is offered when vc-follow-symlinks
is non-nil.
(And when the symlink itself isn't inside a Git repo.)
@domq:
Does this help in your case?
spacemacs uses plain git-gutter
git-gutter just silently fails on symlinked files. (No diffs are shown.)
from git-gutter-plus.
vc-follow-symlinks
does help, but only in the case where the symlink is the final component of the path. (I.e. vc-follow-symlinks
seems to behave like file-chase-links
rather than file-truename
).
Maybe git-gutter+ could change to rely more on vc and vc-git's code to deal with paths, symlinks and tramp? In my current workflow, all vc commands work fine even in the "worst case" (remote file w/ symlinks in directory part of their paths).
from git-gutter-plus.
Related Issues (20)
- git-gutter+ has error in sh-mode sometimes HOT 7
- git-gutter+-stage-hunks doesn't work across Tramp HOT 4
- wrong-number-of-arguments error on package update HOT 10
- git-commit-mode dependency is unavailable HOT 1
- injects git warnings into commit messages HOT 1
- git-gutter+-show-hunk not updating when switching between hunks HOT 1
- Wierd interaction with line numbering
- Update to git-commit.el HOT 1
- Very slow on large files HOT 1
- [FR] stash hunk at point
- [FR] Derive committing mode from git-commit-mode
- (void-variable git-commit-mode-map)
- clarify reason for fork, and maintenance strategy
- Activating git-gutter-plus produces a tramp error during initilisation
- Any plan to add flydiff mode?
- Getting 'Error callling diff" errors with latest magit HOT 1
- Error opening tramp files HOT 22
- feature request: Make git-gutter+-refresh an interactive command
- Feature Request: display file statuses in dired
- possible feature: jump to hunk with completing-read
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-gutter-plus.