Why does trailing newline not count as a line? about crop HOT 3 OPEN

I realize I can secretly append an extra newline at the end of the rope so it always thinks it has a trailing newline, and then carry on as usual while making sure to never touch the trailing newline. But my question still stands, why is Rope implemented like this?

from crop.

That was a deliberate decision to match the behaviour of Rust's String. I kinda regret that now, and changing the trailing newline semantics to match Ropey's has long been on my todo list.

I'd merge a PR if you want to work on it, but keep in mind that Rope{Slice}::line_len(), Rope{Slice}::line() and Lines's {DoubleEnded,Exact}Iterator impls would all have to be changed.

from crop.

I see, that makes a lot of sense. I wonder if there are any people relying on this behavior? I'll try to send a PR for this soon.

from crop.