Object Oriented Programming about auction.mod HOT 9 CLOSED

so, added some (halfhearted) classes

from auction.mod.

I would recommend a structure like this:

• AuctionList Keeps track of Auctions
  • Method to add Auctions
  • Method to set the filters (Resource/Name/Rarity)
  • Method to get the filtered Auctions
• MessageParser Reads the auctions from a String (Called by Network and TradeMessageHandler)
  • Method for parsing human and nonhuman trademessages
• Network and TradeMessageHandler Recieve the Trade Messages from different Sources
  (Both with their own handleMessage-Implementation)
  • Use MessageParser to read the auctions from the message
  • Then add the Auctions to the AuctionList
• Settings Stores Settings like: rowheight, spam-protections ...
  • Set/Get/Save/Load the Settings
• AuctionHouseUI Draws the Auction House
  • Displays the AuctionList
  • Sets the Filters for the List
• GeneratorUI Draws the Generator
• SettingsUI Draws the Settings-Panel
  • Sets the Settings in the Settings-Class
• ScrollHelper
  • Organizes Nicknames for Scrolls
  • Does Scroll->Id and Scroll->ImageId ...
  • Scroll->Amount of Scrolls Owned
  • Uses Dictionarys for O(1) Lookup instead of O(N)
• Prices
  • Gets Prices from ScrollsPost
  • Rounds and formats the Suggested price according to Settings

The Settings class you introduced has nothing to do with the Mod-Settings!

from auction.mod.

better?

from auction.mod.

Its a step in the right direction, yes.

from auction.mod.

Naming Conventions in C#: http://stackoverflow.com/questions/1618316/naming-convention-in-c-sharp

from auction.mod.

Read comment

from auction.mod.

with the last changes, do you agree to closing this issue?

from auction.mod.

I would remove the addcardstolist and additemtolist Methods in Messageparser.cs (Line 75-142), because they not really have a purpose, because the AuctionHouse-class already separates the auctions by WTB/WTS, so one could create one single list in the parse method and add it to the AuctionHouse at once.
But yes, i think we can close this now.

from auction.mod.

deleted addcardstolist, and in additemtolist I'm adding all items to the same list.

from auction.mod.