Comments (9)
so, added some (halfhearted) classes
from auction.mod.
I would recommend a structure like this:
AuctionList
Keeps track of Auctions- Method to add Auctions
- Method to set the filters (Resource/Name/Rarity)
- Method to get the filtered Auctions
MessageParser
Reads the auctions from a String (Called byNetwork
andTradeMessageHandler
)- Method for parsing human and nonhuman trademessages
Network
andTradeMessageHandler
Recieve the Trade Messages from different Sources
(Both with their ownhandleMessage
-Implementation)- Use
MessageParser
to read the auctions from the message - Then add the Auctions to the
AuctionList
- Use
Settings
Stores Settings like: rowheight, spam-protections ...- Set/Get/Save/Load the Settings
AuctionHouseUI
Draws the Auction House- Displays the
AuctionList
- Sets the Filters for the List
- Displays the
GeneratorUI
Draws the GeneratorSettingsUI
Draws the Settings-Panel- Sets the Settings in the
Settings
-Class
- Sets the Settings in the
ScrollHelper
- Organizes Nicknames for Scrolls
- Does Scroll->Id and Scroll->ImageId ...
- Scroll->Amount of Scrolls Owned
- Uses
Dictionarys
forO(1)
Lookup instead ofO(N)
Prices
- Gets Prices from ScrollsPost
- Rounds and formats the Suggested price according to
Settings
The Settings
class you introduced has nothing to do with the Mod-Settings!
from auction.mod.
better?
from auction.mod.
Its a step in the right direction, yes.
from auction.mod.
Naming Conventions in C#: http://stackoverflow.com/questions/1618316/naming-convention-in-c-sharp
from auction.mod.
from auction.mod.
with the last changes, do you agree to closing this issue?
from auction.mod.
I would remove the addcardstolist
and additemtolist
Methods in Messageparser.cs (Line 75-142), because they not really have a purpose, because the AuctionHouse
-class already separates the auctions by WTB/WTS, so one could create one single list in the parse method and add it to the AuctionHouse at once.
But yes, i think we can close this now.
from auction.mod.
deleted addcardstolist, and in additemtolist I'm adding all items to the same list.
from auction.mod.
Related Issues (20)
- Show Amount of Scrolls owned in front to Scroll Name HOT 2
- Only highlight WTS/WTB-Buttons after filters
- spammfilter problem with adding messages HOT 1
- Align Auction table more properly
- Crashed / Disabled Because of multiple auctions of same scroll in same message? HOT 2
- Message Parsing Issue HOT 2
- Not removing duplicates HOT 2
- #: filter not working HOT 1
- Crash on "load WTB msg" HOT 4
- Request: Correct WTB/WTS when cards sold/bought HOT 2
- Crash on "Price >= wts-generator" HOT 3
- PStr only shows auction where scroll owned "> 0"? HOT 2
- Generator - Save/Load Problems HOT 1
- Request: Different Save files HOT 3
- OT: contact
- Problems when joining a game while 'connected'. HOT 1
- Save Settings HOT 1
- System.Collections.Generic.KeyNotFoundException HOT 3
- ingame Network with Channel messages instead of whispers HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from auction.mod.