Git Product home page Git Product logo

Comments (3)

matt-west avatar matt-west commented on August 12, 2024

Issue with auto-scroll to components based on URL hash

from astrum.

RyanHavoc avatar RyanHavoc commented on August 12, 2024

@matt-west I've added an additional check to ensure the document is ready before triggering the scroll to. This fixes the problem, but not entirely in our case with SBL.

See the bug/59 branch.

The issue we have with SBL is we're loading additional Vue components into the library. Astrum triggers the scrollTo once it's completely loaded. You can see the "Done" on the screenshot below:

developer tools - http sbl loc pattern-library

Then additional components render after they hit the endpoints which throws off the viewing position after it's been scrolled to.

I can't think how we could work around this. It's a bit of an edge case for us mind...

from astrum.

matt-west avatar matt-west commented on August 12, 2024

@RyanHavoc I agree that this is an edge case. Happy to go with the solution you've put together.

from astrum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.