Sending MAIL command twice about nodemailer HOT 7 CLOSED

Should be fixed with 1034ae8 - if the server supported only HELO but not EHLO then all commands were sent twice.

from nodemailer.

You are the fastest bug-fixer ever :)

from nodemailer.

Thanks :)

from nodemailer.

Would this also have caused the callback to return twice, i.e. is the callback only supposed to return once?

from nodemailer.

If the response for an EHLO command was erroneos (server didn't support it) then an additional HELO request was made. As there was a bug then the original "thread" (the EHLO one) didn't stop there and tried to continue anyway regardless of the error. Meanwhile HELO ended with success and started it's own separate command "thread" (actually it's not a thread but a callback chain or smth.), so as a consequence a set of two "threads" were sending matching commands to the same connection and thus fireing the callback function also not once but twice (one from the EHLO and one from the HELO thread).

In short - welcome to the wonderful world of callbacks and events :)

from nodemailer.

I've been in this world for a while.

from nodemailer.

I'm encountering this issue. While trying to debug it I noticed that this merge seems to have removed the fix:
andris9@76ec625

from nodemailer.