Git Product home page Git Product logo

Comments (6)

ry avatar ry commented on August 28, 2024

you can see where it failed by looking at the result of http_parser_execute()

from http-parser.

jonashaag avatar jonashaag commented on August 28, 2024

wtf, that was fast. Doesn't http_parser_execute return the number of bytes parsed?

from http-parser.

ry avatar ry commented on August 28, 2024

yes, but it exits immediately if there was an error. so if http_parser_execute() < sizeof(buf) then there was an error (or an Upgrade). You can use this to point out where the error was - which is perhaps more useful than an error code.

from http-parser.

jonashaag avatar jonashaag commented on August 28, 2024

hrm, I'd like to use the return values for indicating the reason why I made http-parser exit; for example after I got the request URL and figured out I want to answer with HTTP 404, it would be comfortable to simply return 404.

If I manually break parsing, I've got a reason to and I most probably want to communicate that reason back to the code that called http_parser_execute so that code can decide what steps to take next.

So please add this feature. :-)

from http-parser.

ry avatar ry commented on August 28, 2024

You can communicate your state (or what action to take) to the code calling http_parser_execute() through your void *data object.

from http-parser.

ry avatar ry commented on August 28, 2024

closing.

from http-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.