Git Product home page Git Product logo

Comments (5)

bnoordhuis avatar bnoordhuis commented on August 28, 2024

Good catch. Anyone want to review bnoordhuis/http-parser@48c4772?

from http-parser.

awick avatar awick commented on August 28, 2024

That fix will break my use of http_parser in an IDS where I'm seeing live urls with form feeds (\f) that actually get processed. Insane, but true.

from http-parser.

bnoordhuis avatar bnoordhuis commented on August 28, 2024

How would that work with another parser? Form feeds are not valid URL characters.

from http-parser.

awick avatar awick commented on August 28, 2024

Agree that they are invalid requests, however I see these requests in the wild and would like to parse them. Looks like apache/php have no problem with them for example. Previous versions of http_parser also seemed to handle them.

For a simple example create a phpinfo.php file with

curl "http://localhost/phpinfo.php?formfeed=form^Ffeed" > /tmp/ff

(Replace the ^F with control-V control-F)

vi /tmp/ff and look for formfeed and you will see the form^Ffeed made it

from http-parser.

bnoordhuis avatar bnoordhuis commented on August 28, 2024

Fixed in b97fdb0. In non-strict mode (HTTP_PARSER_STRICT=0), tabs and form feeds are allowed in URLs. Thanks for the bug report.

from http-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.