Comments (9)
can you provide any more details? (in particular, dep names)
thanks!
from jitsu.
express
Create an express app from CLI, make sure it works in a browser, then deploy it.
Jitsu does not "figure out" the deps in the app.js.
from jitsu.
Okay, I have confirmed this bug. I don't think it has anything to do with Express. It appears that jitsu is overwriting the deps in the package.json after it already finds them. Here is a dump of my output, I'll be creating a new ticket for this:
prompt: scripts.start (server.js): app.js
prompt: version (0.0.0):
warn: About to write /Users/maraksquires/dev/express-test/package.json
data:
data: {
data: name: 'express-test',
data: scripts: { start: 'app.js' },
data: subdomain: 'express-test',
data: version: '0.0.0'
data: }
data:
prompt: Is this ok? (yes):
warn: No application exists for express-test
info: Analyzing your application dependencies in app.js
info: Found new dependencies. They will be added automatically
data: {
data: connect: '>= 1.4.0',
data: express: '>= 2.3.3',
data: mime: '>= 1.2.1',
data: qs: '>= 0.1.0'
data: }
warn: About to write /Users/maraksquires/dev/express-test/package.json
data:
data: {
data: dependencies: {
data: connect: '>= 1.4.0',
data: express: '>= 2.3.3',
data: mime: '>= 1.2.1',
data: qs: '>= 0.1.0'
data: },
data: name: 'express-test',
data: scripts: { start: 'app.js' },
data: subdomain: 'express-test',
data: version: '0.0.0'
data: }
data:
prompt: Is this ok? (yes):
info: Checking app availability express-test
info: Creating app express-test
warn: Your package.json version will be incremented for you automatically.
warn: About to write /Users/maraksquires/dev/express-test/package.json
data:
data: {
data: name: 'express-test',
data: scripts: { start: 'app.js' },
data: subdomain: 'express-test',
data: version: '0.0.0-1'
data: }
data:
prompt: Is this ok? (yes):
warn: Creating new snapshot for version 0.0.0-1
info: Done creating snapshot 0.0.0-1
info: Updating application express-test
info: Activating snapshot 0.0.0-1 for express-test
info: Starting app express-test
info: App express-test is now started at: http://express-test.nodejitsu.com on Port 80
info: Nodejitsu ok
Marak-Squiress-MacBook-Pro:express-test maraksquires$
Notice the second time around it overwrites the deps?
from jitsu.
Starting to test against resolve-analyzer changes / ability against dep injection.
from jitsu.
talked to tj briefly, express now makes a package.json, which makes this fixed if we use newer express stuff ( expressjs/express@6e69c88 ) which should help minorly. Require-analyzer fixes did not solve this. Delving for a deeper solution.
from jitsu.
this is actually a problem with the back end. see https://github.com/nodejitsu/haibu/issues/14 and also a fix in nodejitsu/require-analyzer@30d2372 which handles how express starts the server. but the backend isn't using the most up to date haibu/carapace, so @joemccann : for now, you need to edit your app.js so that it reads
//if(!module.parent){
app.listen(3000)
//}
this will be corrected soon.
from jitsu.
This is fixed in the test environment. Will be deployed to production in the next 48 hours. Checkout the awesome in this gist: https://gist.github.com/999883
from jitsu.
nice
from jitsu.
This has been deployed to production
from jitsu.
Related Issues (20)
- Error when deploying HOT 2
- Feedback when streaming build logs are done
- Deployment exception HOT 2
- Read environment variables locally and set in app
- Save time by allowing domain and name parameters in jitsu deploy command HOT 2
- Build errors not properly displayed
- Cannot deploy applications with make files HOT 1
- Option to avoid writing to package.json HOT 1
- Allow optional delay to watch for immediate errors on deploy HOT 3
- Warn on wrong engine version HOT 5
- Jitsu throws err HOT 3
- When creating a package.json on jitsu deploy, jitsu skips analysing dependencies if entering details when prompted for 'scripts.start'
- Doesn't work behind a firewall with http proxy setup
- npm version and GH version out of sync HOT 1
- Update of *jitsu* docs and implementation needed
- Authentication error is not displayed HOT 1
- Support for "build metadata"? HOT 4
- Cannot update jitsu and unable to deploy app HOT 6
- jitsu deploy doesn't work HOT 3
- Nodejitsu Error 500
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jitsu.