Git Product home page Git Product logo

Comments (6)

Marak avatar Marak commented on August 25, 2024

I literally just replaced the markdown parser with the github flavored markdown parser. Next push should have a fix.

from docs.

Marak avatar Marak commented on August 25, 2024

Hrmm, so that didn't seem to help.

I would really appreciate it if you could hunt down this issue. It's been bugging me and I haven't had the time to track it down. :-(

from docs.

dresende avatar dresende commented on August 25, 2024

The problem is with code highlight. I commented the hl() call in article.js and the encoding problem is gone. I'll dig into the highlighting. Why not go with a browser highlighting? Are you avoiding js on the docs?

from docs.

dresende avatar dresende commented on August 25, 2024

Why not try this one?

http://search.npmjs.org/#/koala (from TJ Holowaychuk)

I would avoid going deep into the vendor folder.

from docs.

jfhbrook avatar jfhbrook commented on August 25, 2024

@dresende @Marak I just gave koala a shot:

https://github.com/nodejitsu/docs/blob/gh-28/lib/generators/article.js#L97-L117

Indeed, it seems that the results from using koala have much fewer encoding errors. However, even with screening out invalid javascript by testing uglify-js's ability to parse the code, I'm now getting a few jsdom "invalid html" warnings. The results look fine, but invalid html can't be good.

Is there a way to reasonably intercept such jsdom errors? Maybe @tmpvar knows.

from docs.

jfhbrook avatar jfhbrook commented on August 25, 2024

This issue has been "hackfixed". It's relatively brittle, but seems to suffice for the docs.

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.