deflate fails on provided sample about pako HOT 10 CLOSED

Thanks, reproduced, that's deflate bug. Need to investigate. Do you have more broken samples or all others passes ok?

For quick check you can just copy all your files to ./test/fixtures in cloned repo and run make test.

from pako.

That's NOT *-raw bug, because this code works:

var fs = require("fs");
var pako = require("pako");

var u8 = new Uint8Array(fs.readFileSync("./index"));
console.log(u8.length);

var deflated = pako.deflate(u8, { level: 4, raw: true });
console.log(deflated.length);
var inflated = pako.inflate(deflated, { level: 4, raw: true });
console.log(inflated.length);

but it fails with level > 4. When your sample added to tests, deflate fails at level > 4.

PS. Edited your post for convenience

from pako.

I found the same issue with this small gif file. Strangely, the tests are green when I put it in the test/fixtures folder (but I get the bug when I do the test manually).

from pako.

Thank you again. I partially fixed bug in master https://github.com/nodeca/pako/commits/master (last commit), that make your first sample work. But found new good sample (previous commit), that crash deflate with ubtyped array and some inflate tests.

To reproduce - rename "_bug" in fixtured to "bug".

from pako.

@andr83 fixed inflate bug in master. Still need to fix last (i hope) bug in deflate, but you already can continue testing (put your samples to fixtures).

If you find more broken samples - let me know.

from pako.

I got an other one :)
https://github.com/Stuk/jszip/blob/master/test/ref/utf8.zip

from pako.

Awesome! It reproduces the same bug in deflate, but sample is very small and easy to debug.

from pako.

Should be ok now. Released 0.1.1

from pako.

I've tested about 400 000 files (my filesystem) without any error. Good job 👍

from pako.

Cool. Big thanks for help with testing.

from pako.