Comments (10)
Thanks, reproduced, that's deflate bug. Need to investigate. Do you have more broken samples or all others passes ok?
For quick check you can just copy all your files to ./test/fixtures
in cloned repo and run make test
.
from pako.
That's NOT *-raw bug, because this code works:
var fs = require("fs");
var pako = require("pako");
var u8 = new Uint8Array(fs.readFileSync("./index"));
console.log(u8.length);
var deflated = pako.deflate(u8, { level: 4, raw: true });
console.log(deflated.length);
var inflated = pako.inflate(deflated, { level: 4, raw: true });
console.log(inflated.length);
but it fails with level > 4. When your sample added to tests, deflate fails at level > 4.
PS. Edited your post for convenience
from pako.
I found the same issue with this small gif file. Strangely, the tests are green when I put it in the test/fixtures folder (but I get the bug when I do the test manually).
from pako.
Thank you again. I partially fixed bug in master https://github.com/nodeca/pako/commits/master (last commit), that make your first sample work. But found new good sample (previous commit), that crash deflate with ubtyped array and some inflate tests.
To reproduce - rename "_bug" in fixtured to "bug".
from pako.
@andr83 fixed inflate bug in master. Still need to fix last (i hope) bug in deflate, but you already can continue testing (put your samples to fixtures).
If you find more broken samples - let me know.
from pako.
I got an other one :)
https://github.com/Stuk/jszip/blob/master/test/ref/utf8.zip
from pako.
Awesome! It reproduces the same bug in deflate, but sample is very small and easy to debug.
from pako.
Should be ok now. Released 0.1.1
from pako.
I've tested about 400 000 files (my filesystem) without any error. Good job 👍
from pako.
Cool. Big thanks for help with testing.
from pako.
Related Issues (20)
- "Error: -3" when inflating chunks of data HOT 2
- How to decompress blob? HOT 2
- Deflate() creating broken zip file
- Use classes to improve tree-shaking HOT 8
- No way to read Deflate data in chunks. HOT 4
- CI: set minimal permissions on GitHub Workflow HOT 2
- Cannot install pako HOT 1
- library initialization slowing down app start
- TypeError: input.subarray is not a function HOT 1
- Docs update: mention what `inflate` and `deflate` actually return
- Incorrect JSDoc type information for optional parameters
- Expecting a new version release HOT 1
- Different 10th byte gzip header between zlib and pako on Mac OS 13 HOT 1
- License declaration in package.json and LICENSE are not the same
- GZIP pako compressed string results in "Not in GZIP format" in JAVA on decompressing HOT 1
- Inconsistency and `undefined` return in `inflate` method between versions v1 and v2
- Using static dictionary, inflateRaw "Uncaught invalid stored block lengths"
- how to gzip multiple files? HOT 1
- Not compatible with Angular v17
- Getting corrupted data on decompressing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pako.