Git Product home page Git Product logo

Comments (10)

GoogleCodeExporter avatar GoogleCodeExporter commented on September 7, 2024
Can you give any specific examples of this offhand, just so I can find it 
easily? Will then work on it before the 1.0 release.

Original comment by jonathan.skeet on 22 Jan 2012 at 8:53

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 7, 2024
For example Asia/Tbilisi is one that has zone lines like this:
  3:00 E-EurAsia    GE%sT   1994 Sep lastSun

America/Pangnirtung has zone lines with the second format:
  -4:00 NT_YK   A%sT    1995 Apr Sun>=1 2:00

Original comment by [email protected] on 23 Jan 2012 at 10:15

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 7, 2024
Thanks - will have a look and see if Joda Time has been changed to support 
this. We're still close enough to their code base to make that the best option 
:)

Assigning to James for the moment, as he's done rather more on the TZ side than 
I have.

Original comment by jonathan.skeet on 23 Jan 2012 at 6:16

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 7, 2024
Reassigning to Jon.

Original comment by james.keesey on 23 Jan 2012 at 7:45

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 7, 2024
Hmm. We definitely *do* have at least some support for "last" and ">=" - it's 
in TzdbZoneInfoParser, currently line 285. It looks like it's been there right 
from the start.

I'm currently seeing some problems with the Tbilisi time zone around 1997, when 
Noda Time says that DST ended on Feb 28th then started again on March 30th. So 
we've got some issues there, but the rest of the transitions match what Joda 
Time is telling me. I haven't tried Pangnirtung yet.

When you say "This of course results in errors" - what errors were you getting? 
Which version of Noda Time were you using? Can you attach a sample program?

Anyway, this has brought up the issue of 1997 at the very least, so it's 
definitely useful :)

Original comment by jonathan.skeet on 24 Jan 2012 at 8:05

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 7, 2024
(Just checked, and Pangnirtung has a similar problem, this time in 1995 and 
2007.)

Original comment by jonathan.skeet on 24 Jan 2012 at 8:07

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 7, 2024
Yeah, I see that there is some code for last and >=, but as far as I can tell 
it is only used in ParseRule and not in ParseZoneLine.

I was using 858:e1efbe66710b.

I was looking into some conversion errors, where converting local time to utc 
was giving different results in joda time and noda time. Some of these errors 
was with Asia/Tbilsi.

The following timezones were wrong for any local date I tried:
EST,GMT+N,HST,MST,Pacific/Johnston - I suspect these were fixed with issue #28, 
but I have not verified it yet.

There were sporadic errors in the time zones listed in the attached CSV file. I 
think these are the ones caused by this zone line parsing bug.

Original comment by [email protected] on 24 Jan 2012 at 8:59

Attachments:

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 7, 2024
So these were errors as in incorrect results, not errors as in exceptions, 
correct?

I've just come to the same conclusion - that basically the same sort of logic 
should be in ParseLine. I'm just trying to work out how to fix it now... 
Unfortunately I won't be able to do much more today, but at least I think we're 
on the same page now :)

Original comment by jonathan.skeet on 24 Jan 2012 at 9:02

  • Changed state: Started

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 7, 2024
> So these were errors as in incorrect results, not errors as in exceptions, 
correct?

Correct, no exceptions, just incorrect results compared to jodatime.
I also double-checked some of these with timezoneconverter.com and they matched 
jodatime's results.

Original comment by [email protected] on 24 Jan 2012 at 9:11

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 7, 2024
Fixed in revision bc932931ecbe - thanks so much for pointing it out.

Will open an issue with a scheme to hopefully provide a longer lasting fix, 
assuming Joda Time is correct...

Original comment by jonathan.skeet on 26 Jan 2012 at 10:00

  • Changed state: Fixed

from nodatime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.