Incompatible with node 18 about nock HOT 7 CLOSED

After fixing some issues with the testsuite's CA and certs not being strong enough for modern OpenSSL, I've run the whole test suite successfully on node v19 with

From d1144d0d00381ff93468cc6bf013c89a9da7eab1 Mon Sep 17 00:00:00 2001
From: webstrand <[email protected]>
Date: Tue, 18 Apr 2023 13:06:22 -0400
Subject: [PATCH] Fix issue with node v19

---
 lib/socket.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/socket.js b/lib/socket.js
index 816102d..5acc4f6 100644
--- a/lib/socket.js
+++ b/lib/socket.js
@@ -40,6 +40,7 @@ module.exports = class Socket extends EventEmitter {
   resume() {}
   ref() {}
   unref() {}
+  write() {}

   address() {
     return {
--
2.40.0

from nock.

@webstrand this change works on v18 and v19?

from nock.

Should we go ahead and merge the PR that adds node 18 to the test matrix, so that we can begin verifying potential fixes?

from nock.

@webstrand this change works on v18 and v19?

I only have access to v19

from nock.

I couldn't find this documented, but you can make it work by adding and importing https://www.npmjs.com/package/node-fetch , which overrides the undici-based fetch.

Until nock has a workaround for undici-based fetch, maybe it can add node-fetch as a dependency?

from nock.

Pretty sure this issue is unrelated to node 18's fetch. It is related to node 18's http and https modules.

from nock.

🎉 This issue has been resolved in version 13.3.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from nock.