Git Product home page Git Product logo

Comments (7)

HannoSpreeuw avatar HannoSpreeuw commented on August 17, 2024

As Faruk noticed, clmfit_nocuda.c and robust_lbfgs_nocuda.c are strangely used by Makefile.gpu.

from sagecal.

fdiblen avatar fdiblen commented on August 17, 2024

@HannoSpreeuw
@SarodYatawatta
is this still the case?
Maybe we can rename these files already.

from sagecal.

SarodYatawatta avatar SarodYatawatta commented on August 17, 2024

some files need more refactoring, so they will be renamed at a later stage

from sagecal.

fdiblen avatar fdiblen commented on August 17, 2024

@SarodYatawatta @HannoSpreeuw
any updates on this issue?
we should fix this before the next release

from sagecal.

SarodYatawatta avatar SarodYatawatta commented on August 17, 2024

No update yet. Only after October.

from sagecal.

fdiblen avatar fdiblen commented on August 17, 2024

This issue makes GPU support complicated.
Suggestions:

  • filenames that are not related to the GPU implementation should never include 'cuda' keyword. For example: robust_lbfgs_nocuda.c
  • if the file will be compiled with gpu support, it should always include '_cuda' at the end. Example:
    rtr_solve_robust_cuda.c
  • Some files has '_cuda' and they should be renamed for consistency.
    • rtr_solve_robust_cuda_admm.c --> rtr_solve_robust_admm_cuda.c

from sagecal.

fdiblen avatar fdiblen commented on August 17, 2024

related to #42

from sagecal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.