Git Product home page Git Product logo

Comments (7)

simonspa avatar simonspa commented on June 27, 2024 1

I will look into proposing a patch to NC to at least get this fixed for future versions.

from ansible-role-nextcloud.

simonspa avatar simonspa commented on June 27, 2024

There are more issues with the way we currently upgrade:

  • Tiny issue: the updater.phar now asks a question, so we need to pass the --no-interaction flag
  • More conceptual issue: we are not using the upgrader itself but just download and install a new version as far as I understand the code. This means:
    • either we just drop the file son top of the old installation (not so clean), especially as a new instanceId and password salt are generated I guess? Or we would need to copy over the config.php?
    • or we lose all manually installed apps (related to #33 (comment)) which are not in nextcloud_apps.

Is there a reason for not resetting the file permissions, then directly using the upgrader and then setting file permissions properly again?

from ansible-role-nextcloud.

nkakouros avatar nkakouros commented on June 27, 2024

Extracting the files on top of the old ones is a valid option to upgrade Nextcloud. config.php and manually installed apps will not be removed as the nextcloud archive will not overwrite those when extracted.

But, if we implement checks so that the maximum major version to be installed is that specified in nextcloud_version, then I guess there is not much against the automatic update. It does automatic backups and other stuff that are useful.

from ansible-role-nextcloud.

simonspa avatar simonspa commented on June 27, 2024

I'm being very petty here, but the manual says:

Rename your current Nextcloud directory, for example nextcloud-old.

Unpacking the new archive creates a new nextcloud directory populated with your new server files. Move this directory and its contents to the original location of your old server. For example /var/www/, so that once again you have /var/www/nextcloud.

So they don't extract on top but replace the whole folder

from ansible-role-nextcloud.

nkakouros avatar nkakouros commented on June 27, 2024

You are right, it is cleaner this way. In any case, let's use the occ utility to upgrade. We should have versions checks though so that the user can "lock" the nextcloud major version.

from ansible-role-nextcloud.

simonspa avatar simonspa commented on June 27, 2024

This is a bit more annoying than I thought:

$ sudo -u www-data php occ upgrade:check
Nextcloud 16.0.6 is available. Get more information /* ... */
Update for files_rightclick to version 0.15.1 is available.
2 updates available

Cool, so we can simply update and end up at the right place (i.e. not jumping versions)? No!

$ sudo -u www-data updater/updater.phar
Nextcloud Updater - version: v16.0.0beta3-4-gc7a4074

Current version is 16.0.0.

Update to Nextcloud 17.0.1 available. (channel: "stable")
Following file will be downloaded automatically: https://download.nextcloud.com/server/releases/nextcloud-17.0.1.zip

from ansible-role-nextcloud.

simonspa avatar simonspa commented on June 27, 2024

nextcloud/updater#254

from ansible-role-nextcloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.