Sometimes the boot entry title is missing generation + build time about lanzaboote HOT 9 CLOSED

I do notice the same behavior.

from lanzaboote.

I will say, reviewing the image I posted, it's a bit odd that my nixpkgs git rev seems to ... change/advance and then revert back. I'm super jet-lagged so I'm afraid to speculate further right now.

from lanzaboote.

Can you objdump the UKI in question (or better only the .osrel section)? I don't see a code path that can silently fail when generating the os-release (which determines how a generation is displayed). If the tool can't read the build time, for example it would display: "Generation ${X}, Built on Unknown". The generation number needs to be available otherwise lzbt fails.

from lanzaboote.

Same here:

Wow. My display is dirty. ;)

Let me extract some osrel sections...

from lanzaboote.

Broken:

/boot/EFI/Linux🔒 
❯ objdump -s -j .osrel nixos-generation-445.efi

nixos-generation-445.efi:     file format pei-x86-64

Contents of section .osrel:
 1400203cc 49443d6c 616e7a61 0a505245 5454595f  ID=lanza.PRETTY_
 1400203dc 4e414d45 3d4e6978 4f532053 746f6174  NAME=NixOS Stoat
 1400203ec 2032332e 30352e32 30323330 3930352e   23.05.20230905.
 1400203fc 34303737 61306520 284c696e 75782036  4077a0e (Linux 6
 14002040c 2e352e31 290a5645 5253494f 4e5f4944  .5.1).VERSION_ID
 14002041c 3d47656e 65726174 696f6e20 3434352c  =Generation 445,
 14002042c 20427569 6c74206f 6e203230 32332d30   Built on 2023-0
 14002043c 392d3037 0a                          9-07.           

Good:

/boot/EFI/Linux🔒 
❯ objdump -s -j .osrel nixos-generation-443.efi

nixos-generation-443.efi:     file format pei-x86-64

Contents of section .osrel:
 1400203cc 49443d6c 616e7a61 0a505245 5454595f  ID=lanza.PRETTY_
 1400203dc 4e414d45 3d4e6978 4f532053 746f6174  NAME=NixOS Stoat
 1400203ec 2032332e 30352e32 30323330 3832322e   23.05.20230822.
 1400203fc 61313666 37656220 284c696e 75782036  a16f7eb (Linux 6
 14002040c 2e342e31 31290a56 45525349 4f4e5f49  .4.11).VERSION_I
 14002041c 443d4765 6e657261 74696f6e 20343433  D=Generation 443
 14002042c 2c204275 696c7420 6f6e2032 3032332d  , Built on 2023-
 14002043c 30382d32 370a                        08-27.  

from lanzaboote.

It seems systemd-boot only shows VERSION_ID when PRETTY_NAME is not unique. At least that would be my guess when looking at my and @colemickens screenshots.

So should we just add the generation number to PRETTY_NAME if people want to know it?

from lanzaboote.

Alternatively, maybe a feature request to systemd-boot to always display VERSION_ID, or an option to do so?

from lanzaboote.

It's probably easier to include the generation number in the pretty name.

from lanzaboote.

It seems systemd-boot only shows VERSION_ID when PRETTY_NAME is not unique.

Thats pretty surprising behaviour. We should open a systemd issue, but I agree that we should fix it quickly by including the generation number in pretty name.

from lanzaboote.