Git Product home page Git Product logo

Comments (7)

flokli avatar flokli commented on June 29, 2024 1

I'm sorry, I only carried @amjoseph-nixpkgs ' patches to here, and am not too familiar with the cross architecture.

from crate2nix.

kolloch avatar kolloch commented on June 29, 2024

@Ericson2314 I think that you wrote the original tests and know waaaay more about cross-building than I do :) If you could help, it would be appreciated.

from crate2nix.

kolloch avatar kolloch commented on June 29, 2024

@flokli / @amjoseph-nixpkgs I'd really appreciate help here -- pinged you since you seem to know and care about cross-compiling.

  1. Checkout crate2nix
  2. Execute the test that is now skipped by default
    nix build -L \
      --option log-lines 100 --show-trace --out-link ./target/nix-result \
       -f ./tests.nix empty_cross.forceSkipped
    

Check out what the heck is going wrong with https://github.com/nix-community/crate2nix/tree/master/sample_projects/empty_cross.

Thank you!!

from crate2nix.

Ericson2314 avatar Ericson2314 commented on June 29, 2024

CC @alyssais I'll take a look at this, but I might need your help :)

from crate2nix.

 avatar commented on June 29, 2024

I'm sorry, I only carried @amjoseph-nixpkgs ' patches

lolwut? not my commit:

$ git show --format=full 95e3997dc9b806090e5f8c7adff80acfee14714a | egrep 'Author|Commit'
Author: Florian Klink <[email protected]>
Commit: Florian Klink <[email protected]>

The test does some special setup steps in its default.nix

Yeah the monkeying around that it is doing with stdenv internals is totally crazy. IMHO it "worked by accident" before. You should drop that test or split it into a sequence of tests that each do one small thing -- it's trying to do too many things at once, so when it fails eval like this it really doesn't tell us anything except "something is bad".


If you replace -none-elf with -linux-gnu in the test the problem goes away. This issue affects only the -none-elf targets, which are weird ones to begin with. Could you please update the title of this issue to reflect that? This is a "kernel-less target" problem, not a general cross problem.

from crate2nix.

flokli avatar flokli commented on June 29, 2024

I'm sorry, I only carried @amjoseph-nixpkgs ' patches

lolwut? not my commit:

$ git show --format=full 95e3997dc9b806090e5f8c7adff80acfee14714a | egrep 'Author|Commit'
Author: Florian Klink <[email protected]>
Commit: Florian Klink <[email protected]>

Yes, you're not the author of the commits in crate2nix, but they originate from your CLs in depot, as you commented in #309 (comment).

I only meant to say I was doing that upstreaming and don't feel qualified enough with the nixpkgs cross architecture to help out with the specific issue discussed here (#319). Thanks for picking it up!

from crate2nix.

Ericson2314 avatar Ericson2314 commented on June 29, 2024

Hmm, I though I made the freestanding cross test :)

from crate2nix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.