Comments (7)
Sounds like #127?
from buildbot-nix.
@MagicRB is it still on your agenda to convert buildbot-nix into only using the GitHub app for everything?
from buildbot-nix.
Yep, I should get to it this weekend
@MagicRB is it still on your agenda to convert buildbot-nix into only using the GitHub app for everything?
Was planning to start earlier, but then my parents came to visit and then right after I got sick. So that ate two weeks :)
from buildbot-nix.
@MagicRB you can steal the code for re-newing GITHUB_TOKEN's from an github app from here: https://github.com/NixOS/nixpkgs-merge-bot/blob/1aad9bf9b570889da6555650f82d670fc2f73658/nixpkgs_merge_bot/github/GitHubClient.py#L218
You want to use buildbot's secret backend likely because than you can read the token from a file. Those github tokens need to be refresh every hour or so. Last time I read the buildbot code, I think there was one case where it wouldn't use the secret backend and cache the the token - but we can probably patch and upstream the fix. Unfortunately I don't recall where this was the case and if it was fixed.
from buildbot-nix.
The PR exists, the code is in place, a mess has been created: #156
Next step: refactoring
from buildbot-nix.
@lorenzleutgeb #156 is in place, is that enough for your use case? Or do you still desire file-grained PATs?
from buildbot-nix.
I believe so. Otherwise feel free to re-open this.
from buildbot-nix.
Related Issues (20)
- buildbot-nix access control for private repos HOT 7
- Add integration tests
- UX: Links back to the repos
- Better error handling on boot HOT 9
- Support rendering HTML outputs
- Parse the Nix evaluation warnings and display them in the UI HOT 1
- Build the frontend from source
- Org members cannot stop builds HOT 8
- pull based CI runs
- Reporting issue when there are too many checks HOT 29
- JWT token creation is unreliable HOT 14
- Generic OIDC auth HOT 7
- Create upstream patches for additions to `buildbot`
- Cache failed builds HOT 11
- Pull changes from Lix fork HOT 1
- Build failure with `error: writing to file: Broken pipe` HOT 1
- `authBackend.none = {}` is not acconted for at all
- GC root registration steps show up in buildbot HOT 1
- Use GitHub "checks" to provide more detail than "status reports"
- Intermittent cross-comp errors when many builds are queued HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buildbot-nix.