move react and react-dom to peer dependancies about animate-components HOT 23 CLOSED

absolutely :)

from animate-components.

yep, it should make no difference what so ever for any end user, just lets those of us that want to use fiber beta use it without this lib pulling an older version.

from animate-components.

umm.. could you create a PR for that ? I'm a little busy with an another project so it may take a while to push the changes 😄

from animate-components.

Thank you so much!!

from animate-components.

Update the build size when you run the webpack 👍

from animate-components.

Update the build size when you run the webpack 👍

need more coffee apparently, what you're asking went right over my head

from animate-components.

i "think" that's what you're asking for lol

from animate-components.

PR made at #19

from animate-components.

Did you ran all the test and checked everything locally ?

from animate-components.

shouldn't break anything since everything is stable 😅

from animate-components.

could you do a tag so we can consume it? please/thanks

from animate-components.

Elaborate !

from animate-components.

a release/tag so we can install via npm?

from animate-components.

umm.. you made changes to package.json which was in root, right ?

from animate-components.

No changes were made to animate-components.

from animate-components.

am i mistaken, but i thought npm used tags to get versions which are based on particular commits?

from animate-components.

There were no changes to the core and this fix was for the package.json which was in root. So I think we don't require a new version for animate-components

from animate-components.

But still thanks for the changes 😄

from animate-components.

anytime, but without even a patch version bump (x.x.1) no one can consume the changes via yarn/npm

from animate-components.

Ok I will publish the new version! Just give me some time.. a little busy here !

from animate-components.

no worries, thanks again!

from animate-components.

Here you go - ✨ [email protected]

from animate-components.

Fixed some other issues as well (btwn you didn't notice them 😅 )

from animate-components.