Number-keyed properties about babel-plugin-object-to-json-parse HOT 5 CLOSED

Thank you for reporting!
Maybe, I fixed this issue by #13.
Please confirm 🙇

from babel-plugin-object-to-json-parse.

This is very good, but I have to mention one sad thing.

I've just noticed that converting number-keyed properties may change the meaning of programs because the result of converting a number to a string using ToString is implementation-dependent as per the spec.

Example:

// before
var obj = {77777777777777777: "foo"};
console.log(obj[77777777777777777]); // => "foo"

this program outputs "foo" in all browsers.
However, the program after conversion behaves differently in IE11:

// after
const obj1 = JSON.parse('{"77777777777777780":"foo"}');
console.log(obj1[77777777777777777]); // => "foo" (Chrome) / undefined (IE11)

This program still outputs "foo" for Chrome, but IE11 shows undefined for the same program.

Therefore, we might want to not convert objects with number-keyed properties.

from babel-plugin-object-to-json-parse.

It might be good to allow conversion of numeric keys if they are safe integers.

from babel-plugin-object-to-json-parse.

I fixed this issue by using Number.isSafeInteger. (#15 )
Can I close this issue?

from babel-plugin-object-to-json-parse.

Seems very nice; thank you!

from babel-plugin-object-to-json-parse.