Comments (5)
Committed (I did some changed to the test but it's functionally equivalent)
Original comment by [email protected]
on 12 May 2010 at 9:03
- Changed state: Fixed
from google-refine.
Great. Thanks Stefano - it wasn't quite production ready, so thanks for
cleaning it
up and committing.
As an aside, normally I'd have guard clauses on the functions to throw
IllegalArgumentException if a null value is passed as a parameter (which I was
testing for). I notice you changed the test to expect ServletException.
I'd prefer to see IllegalArgumentException (or whatever the Java Equivalent of
.Net's
ArgumentNullException is), as it's then obvious that the problem isn't with the
method but with the parameter passed in to it - which saves time in the
debugging.
Original comment by iainsproat
on 12 May 2010 at 10:28
from google-refine.
Original comment by iainsproat
on 17 May 2010 at 12:03
- Changed state: Verified
from google-refine.
Original comment by tfmorris
on 18 Sep 2012 at 2:21
- Added labels: Milestone-2.0
from google-refine.
Original comment by tfmorris
on 18 Sep 2012 at 2:52
- Added labels: Milestone-1.0
- Removed labels: Milestone-2.0
from google-refine.
Related Issues (20)
- Index out of range: -1 when creating project from local compressed file HOT 1
- Provide preview parser for RDF importers HOT 1
- Update gdata client libs HOT 4
- importing-controller error with JSON file HOT 3
- Refine is damaged - won't open HOT 5
- HtmlText GREL function locks up Google Refine HOT 2
- row processing java class HOT 1
- Diff Dates returning NULL
- Add ANDed behaviour to intra-facet operations HOT 1
- Butterfly classloader deadlock
- Patch: Update Freebase suggest widget HOT 9
- Switch to released version of Freebase reconciliation service HOT 1
- Minor patch: Use new suggest widget HOT 1
- Change branding from Google Refine to OpenRefine HOT 1
- Review How Dates Are Exporting using Template Function
- Unable to run the Augmentaton code to fetching URLs based column
- Refine is open as defaul in IE
- Adding column based on column not working?
- ASC
- KCP
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-refine.