Git Product home page Git Product logo

Comments (5)

GoogleCodeExporter avatar GoogleCodeExporter commented on August 14, 2024
Committed (I did some changed to the test but it's functionally equivalent)

Original comment by [email protected] on 12 May 2010 at 9:03

  • Changed state: Fixed

from google-refine.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 14, 2024
Great.  Thanks Stefano - it wasn't quite production ready, so thanks for 
cleaning it 
up and committing.

As an aside, normally I'd have guard clauses on the functions to throw 
IllegalArgumentException if a null value is passed as a parameter (which I was 
testing for).  I notice you changed the test to expect ServletException.

I'd prefer to see IllegalArgumentException (or whatever the Java Equivalent of 
.Net's 
ArgumentNullException is), as it's then obvious that the problem isn't with the 
method but with the parameter passed in to it - which saves time in the 
debugging.

Original comment by iainsproat on 12 May 2010 at 10:28

from google-refine.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 14, 2024

Original comment by iainsproat on 17 May 2010 at 12:03

  • Changed state: Verified

from google-refine.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 14, 2024

Original comment by tfmorris on 18 Sep 2012 at 2:21

  • Added labels: Milestone-2.0

from google-refine.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 14, 2024

Original comment by tfmorris on 18 Sep 2012 at 2:52

  • Added labels: Milestone-1.0
  • Removed labels: Milestone-2.0

from google-refine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.