Comments (1)
Hi Stefan,
Thanks so much for your contribution. This is very interesting. I have to admit that this is the first time I have heard of sax, so I will have to read the paper you refer to in order to understand a little bit more what this actually does. The examples you wrote are helpful in this regard, but an additional way you could help me with to wrap my head around this is to flesh out use-cases for this representation in the form of tests. You can write those in this file: https://github.com/slnovak/nitime/blob/master/nitime/tests/test_timeseries.py
Once I understand a little bit better what these are, I can comment more on 'where to put this'. If you think about the sax as a transform of the data, analogous to a spectral transform, maybe a better place to put this would be in the algorithms library. I should warn you that I am currently working on a refactor of the code, which will result in a breaking up the algorithms file into several different sub-modules (see the work here: https://github.com/arokem/nitime/tree/reorganization) and better test coverage (we are close to 100% coverage for the algorithms sub-module!). We plan to continue this work, by breaking up utils.py, analysis.py, timeseries.py and viz.py into sub-modules in a similar fashion. This should eventually make it easier to contribute, but for now makes for some divergence between branches. In other words, if you want to add things to the algorithms sub-module, maybe you should branch off of the reorganization branch and we would merge your additions into that one. If that's a hassle, then don't worry about it. We can figure out a way to merge all this together eventually. Which brings me to the distance metrics - are you planning to implement the distance metrics mentioned in the Lin et al. paper? I think that it would be the best to put those in the algorithms sub-module. Maybe add a new file called 'distance' into the algorithms sub-module, in a branch off of the reorganization branch and the tests for these distance metrics under algorithms/tests/test_distance.py, or something of the sort. How does that sound?
Again - thanks a lot for your work on this!
Cheers,
Ariel
from nitime.
Related Issues (20)
- feature request: multiple `p` values for `detect_lines` HOT 1
- Failing tests with nibabel 3.2.0 HOT 3
- What is the Entropy Estimation Based on? HOT 2
- nitime not installing in Jupyter HOT 2
- will it work for multivariate time series prediction both regression and classification
- nitime.analysis.coherence.MTCoherenceAnalyzer causing an error when fed with bandwidth parameter HOT 3
- Will this work for analyzing multichannel EcoG data from rat cortex? HOT 1
- tsa.periodogram() returns frequencies of all 0s when Fs=1. HOT 3
- negative values in confidence interval of multi-taper coherence HOT 8
- I can't install nitime with pip HOT 3
- `test_FilterAnalyzer` fails with scipy 1.8.0 HOT 1
- `test_psd_matlab` fails with matplotlib 3.6.2 HOT 2
- Test with Python 3.12 / numpy 1.26
- test_viz.py failure with "ValueError: Masked arrays must be 1-D" HOT 6
- New release HOT 2
- Test failures for 32 bit architectures HOT 2
- Could you provide `aarch64` wheels? HOT 2
- numpy 2.0 compatibility HOT 9
- Test failure on aarch64 HOT 1
- Release procedure does not create a GitHub release HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nitime.