Git Product home page Git Product logo

Comments (3)

stof avatar stof commented on June 19, 2024

Here is my proposal:

  • drop support for Twig versions passing the cache folder to the loader (do you really need to keep support for Twig 0.9.2 and older ? Is there anyone really using it recently ?)
  • go back to a single engine then (as the only difference would be the usage of the deprecated Twig_Autoloader then, and you can use your own autoloader even in Twig 1.x, removing the need to ignore the deprecation)

what do you think ?

from twigfiddle.

ninsuo avatar ninsuo commented on June 19, 2024

From data, I see that the oldest version used so far is Twig 1.1.0.
And as soon as twigfiddle claims to support 1.x and 2.x, I've nothing against removing support to 0.x.
Or I may even use V1 twig engine just for Twig 0.x.

from twigfiddle.

ninsuo avatar ninsuo commented on June 19, 2024

Now, Twig 2.x and 1.x use V2 engine, where Twig 0.x uses engine V1.
In Twig-0.9.10 (last version supported), Loader doesn't take a 2nd argument, so there will be no issues.

from twigfiddle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.