Git Product home page Git Product logo

Comments (2)

nilsmehlhorn avatar nilsmehlhorn commented on June 8, 2024

While the user does changes to the data (manual processing) the undo & redo shoud be enabled. As soon as the user triggers the automatic processing, he shouldn't be able to do undo & redo as long as the automatic processing is running.

You can already prevent the user from performing undo/redo by e.g. disabling the corresponding buttons/key combinations. Otherwise you could also split undo/redo actions into two parts (one for triggering, one for performing) and funnel them through an effect that filters the latter based on your criteria.

But the problem is, that the automatic process uses the same actions that are allowed to be redone/undone.

As you correctly pointed out, that is the actual problem. Why not introduce separate actions for the automated processing and let them be ignored by ngrx-wieder?

Watch out though, the latest step in history probably won't make sense when applied on top of the result of your automated processing. As far as I understood, you'll probably have to undo the automated processing as well if you want to keep the history.

from ngrx-wieder.

julianpoemp avatar julianpoemp commented on June 8, 2024

As you correctly pointed out, that is the actual problem. Why not introduce separate actions for the automated processing and let them be ignored by ngrx-wieder?

Your're right... I think this solution is more beautiful than mine. But if I do it that way I have to make more changes than simply introducing few, new actions. I'll think about it, thanks!

from ngrx-wieder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.