energy unit options in figures about arc-alkali-rydberg-calculator HOT 7 CLOSED

Hello @petermao . That is very useful addition. I opened branch energyunits to which you can submit a pull request.
I will do just a quick review and merge with master then. Many thanks for taking time to contribute!

from arc-alkali-rydberg-calculator.

Hi @nikolasibalic, I need permission to push to that branch.

In case my comments were insufficient, 'eV' and 'GHz' are specified by those strings, without case-sensitivity. for 1/cm, I just check that 'cm' is in the units string (also not case sensitive). The Y-axis label for energy is hard-coded after unit-type detection.

from arc-alkali-rydberg-calculator.

@petermao Access for direct commit to that branch should work now, I sent invitation.
Alternatively you can also submit a pull request to that branch.

from arc-alkali-rydberg-calculator.

pushed! I didn't realize I could make a pull request from a local branch.

from arc-alkali-rydberg-calculator.

Many thanks! It looks great. I will add to main branch and release new version with the updates later today.

from arc-alkali-rydberg-calculator.

@nikolasibalic: I'm glad to be of help. It's a great package you've put together here.

btw -- the python notebooks will crash in some places. they'll need global replace of "units=2" with "units='ghz'" at a minimum.

from arc-alkali-rydberg-calculator.

This implementation is available now via pip as version 3.0.12.

from arc-alkali-rydberg-calculator.