Git Product home page Git Product logo

Comments (12)

NiklasPor avatar NiklasPor commented on July 17, 2024 1

Should be resolved in #49 .

from prettier-plugin-go-template.

richtera avatar richtera commented on July 17, 2024

So it seems to be that if you have a file with a missing {{ end }} it seems to affect other files when using this plugin within visual studio. If you never open that file things are ok, but once you open that file it seems to prevail until you restart visual studio.

from prettier-plugin-go-template.

cpence avatar cpence commented on July 17, 2024

Same issue here; as far as I can tell, if you ever save a file with a missing {{ end }}, you have to restart VSCode. =(

from prettier-plugin-go-template.

NiklasPor avatar NiklasPor commented on July 17, 2024

Ah that's good input @cpence & @richtera. I guess I know why this is happening.
I'll try a quick fix 👍

from prettier-plugin-go-template.

NiklasPor avatar NiklasPor commented on July 17, 2024

@richtera @cpence should be fixed in 0.0.11-beta.4.

Would be nice if one of you could confirm that the version resolves the error.
I'll publish it as the latest version then. Already tested it myself and seems to work just fine:

npm i [email protected]
(Don't forget to restart VSCode / Extension Host after installing.)

Thanks for your help ❤️

from prettier-plugin-go-template.

NiklasPor avatar NiklasPor commented on July 17, 2024

@all-contributors please add @cpence for bug

from prettier-plugin-go-template.

allcontributors avatar allcontributors commented on July 17, 2024

@NiklasPor

I've put up a pull request to add @cpence! 🎉

from prettier-plugin-go-template.

cpence avatar cpence commented on July 17, 2024

As far as I can tell, the fix works! Thanks so much!

from prettier-plugin-go-template.

richtera avatar richtera commented on July 17, 2024

Hmmm, I am getting problems when using this commit version from the command line.
Example file

{{ $commitId := index .Site.Params.courseInfo .Parent.Params.meta.id "commitId" | default "" }}
{{ $courseSha := index .Site.Params.courseInfo .Parent.Params.meta.id "sha" "course" .Parent.Params.meta.id | default "" }}
{{ $lessonSha := index .Site.Params.courseInfo .Parent.Params.meta.id "sha" "lesson" .Params.meta.id | default "" }}
<div
  class="course-card m-auto"
  data-bind="{{ printf "using: getLesson({ courseId: %s, lessonId: %s, courseSha: %s, lessonSha: %s, commitId: %s })" (.Parent.Params.meta.id | jsonify) (.Params.meta.id | jsonify) ($courseSha | jsonify) ($lessonSha | jsonify) ($commitId | jsonify) }}"
>
  <div class="lesson-svg overall-button" style="cursor: pointer;">
    <a class="course-button plain" href="{{ .RelPermalink }}">
      <circle-dial
        params="value: overallQuestionsPCorrect, nullText: ''"
      ></circle-dial>
      <p class="text-center">
        {{ .Params.heading | plainify | markdownify }}
      </p>
    </a>
  </div>
</div>
themes/ui/layouts/test-prep-lessons/lesson-list-item-first.html
[error] themes/ui/layouts/test-prep-lessons/lesson-list-item-first.html: SyntaxError: Unexpected closing tag "div". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags (18:1)
[error]   16 |     </a>
[error]   17 |   </div>
[error] > 18 | </div>
[error]      | ^^^^^^
[error]   19 | 

It's somehow losing track of counting in some cases now. Not sure how it would be related.

from prettier-plugin-go-template.

richtera avatar richtera commented on July 17, 2024

I think it may have something to do with {{ }} inside of quotes or attributes or in the same line.
I also see problems in the following case:

|   <div class="question-stem ck-content">
[error] > 3 |     {{ .Params.content | replaceRE "<blank (.*?)</blank>" "<blank class=\"blank\"></blank>" | safeHTML }}
[error]     |                                                 ^^^^^^^^
[error]   4 |   </div>
[error]   5

from prettier-plugin-go-template.

NiklasPor avatar NiklasPor commented on July 17, 2024

@richtera Looks like the error is coming from " inside {{ }}. I'll check whether this is also a quick fix.

from prettier-plugin-go-template.

richtera avatar richtera commented on July 17, 2024

FYI this doesn't happen in the release version.

from prettier-plugin-go-template.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.