Git Product home page Git Product logo

Comments (29)

b3pio avatar b3pio commented on August 27, 2024 3

@nikitasius Any chance to publish on F-droid / IzzyOnDroid repo? Also can you consider removing Google.Firebase?

from telegraher.

Rush-er avatar Rush-er commented on August 27, 2024 3

@nikitasius Thanks for the amazing client !
I found a issue / feature missing, i'm currenty on a microg system and GMAPS does't work.

It's possibile to add support for OSM map provider like in Telegram Foss or NekoX ?
https://github.com/Telegram-FOSS-Team/Telegram-FOSS/search?q=maps&type=commits

from telegraher.

b3pio avatar b3pio commented on August 27, 2024 2

@nikitasius this is great news! you may need to remove this from code for f-droid approval.

Google Firebase Analytics

*Google Firebase Analytics
2com.google.firebase.analytics.

from telegraher.

alvkN avatar alvkN commented on August 27, 2024 1

you can use implementation of 5 from CatoX, it better than neko and others (swipe back doesn't open hidden ALL tab)

from telegraher.

OshekharO avatar OshekharO commented on August 27, 2024 1
  • Forward Without Quoting ( in Channels & Groups )
  • Delete From Cache ( in Channels & Groups )
  • Mark all read
  • Save to cloud ( in Channels & Groups )
  • Proxy from nekogram
  • Copyright Infringement Blocked Bots, channels & groups Unlocked
  • Option to delete all my messages from the group
  • Add "Go to first message" to three dot menu ( in Channels & Groups )
  • Inbuilt Updater ( Like Nekogram or mdgram )
  • Add Amoled Theme As default
  • Unlimited Pinned option
  • Custom audio bitrate in group Voip (64gram)
  • [Redesign] Settings like mdgram
  • More optimization ( overall )
  • Add to favourites to three dot menu
  • Voice Changer
  • Manage inactive channels ( hulugram )
  • Copy selection ( in Channels & Groups )
  • Add Independent Section For Bots List ( ime Messenger {botlist.net or botsarchive.com} )
  • Keep the original file name when downloading files
  • Option to ignore Android-only content restrictions
  • Retract Vote ( mdgram & plus messenger )

@nikitasius check this out

from telegraher.

nikitasius avatar nikitasius commented on August 27, 2024 1

Well, i spoken with a Barinsta dev and looks like fdroid will not remove us if TG will ask them. Sounds good.
I will prepare the app for fdroid. Hope it they will be able to build is fine.

But remember:

  • if fdroid build it, you/me/anyone will need to remove old app due another signature (they will sign with their fdroid keys)

from telegraher.

 avatar commented on August 27, 2024 1

@nikitasius just make your own f-droid repo...

from telegraher.

b3pio avatar b3pio commented on August 27, 2024 1

@AlbertEienstein, @IzzySoft 's repo would probably be a better option than maintaining his own repo for less work and more exposure for users to find this app. So either Izzys can be the repo it lives on or just as a stepping stone to main f-droid repo.

from telegraher.

IzzySoft avatar IzzySoft commented on August 27, 2024 1

All true what @b3pio writes. But keep in mind that the per-app size limit in my repo is 30M – even the smallest current APK is already beyond that. As apps tend to rather grow than shrink, I'm hesitant adding an app that's already over this limit to start with.

from telegraher.

nikitasius avatar nikitasius commented on August 27, 2024 1

Hi folks, thanks for a good ideas here 👍
@AlbertEienstein it;s interresting but while there are many other passionate folks who do it better than me, it's great.
@IzzySoft repo sounds good. @b3pio i will try to clean this fork (remove completely fcm) and to see what will be changed and how it will affect the final size.
If i will use my own keys (actually this repo use the default keys, everyone knows them), i will generate them and i will add into github secrets (if i use CI/CD here). Actually i did not changed it because idk if it goes to fdroid or any another repo (and another repos can build and sign with their own keys).

from telegraher.

IzzySoft avatar IzzySoft commented on August 27, 2024 1

@nikitasius seeing your enthusiasm, I certainly don't want to be the one on the brakes here. 30M is no hard limit (it's because all this runs on my personal resources only and I somehow have to limit it); 32M would be a technical limit (for uploading the file to VirusTotal via their APIv2 which I use, to have it scanned), but as long as exceptions are few I can work around that (using some v3 calls I've implemented). So those 2M are mostly a safety buffer.

TL;DR: if you can get the size down a bit that would be great, but if it's a little (!) over 30M I can close an eye or two on that. Let me know then, and I'll take a look if the other conditions are met – when you're ready.

Concerning FCM: May I feed your enthusiasm by pointing you to some alternative push services like @UnifiedPush – or if needed, also to full Firebase alternatives like appwrite or Supabase? 😃

from telegraher.

heller390 avatar heller390 commented on August 27, 2024 1

@heller390 you mean same like desktop have? i did not added it nor checked how does it work. By default we ignore all what we can ignore. But i will take a look to this option.

Actually you can use tg desktop on linux to disable it.

It would be highly helpful if u can add a toggle in telegrapher settings in the upcoming build.

from telegraher.

IzzySoft avatar IzzySoft commented on August 27, 2024 1

so here are the APKs, built on a server, you can analyze them

My APK library scanner confirms there seem to be no offending libs. But unfortunately the APKs are 35M+ – which is beyond the limit of 30M per application in my repo. This might be due to the beta having some additional debug code in, I cannot tell.

i wanna change readme/description

ideally, set up Fastlane structures with the app's repo, so you're in control of how the app is presented. For formatting of the full description, you can find some hints here.

there are 4 apks

I can only pick one per package name.

because new version will not work as an update for the old ones i wanna change app signature.

In that case, consider changing package name (applicationId) instead/too to avoid confusion.

why i find good to use your repo

Thanks – and yes, that was part of the idea: keeping the barriers low. But at the same time, keeping the door to f-droid.org open and focused, if possible 😉

from telegraher.

nikitasius avatar nikitasius commented on August 27, 2024

you can use implementation of 5 from CatoX, it better than neko and others (swipe back doesn't open hidden ALL tab)

Thanks i will check for this 👍

from telegraher.

nikitasius avatar nikitasius commented on August 27, 2024

@OshekharO cool 👍

@b3pio it's a good idea. Actually TG want us to stop. I sent them some questions and i need their answers. When they will answer me i will tell you better. Their answer will be shared with the chat (TG and Matrix).
For me safety of users is the most important but some features can show different app behavior and signal "hey, it;s probably telegraher". So, if there are no negociations with TG some future features cannot be implemented because they will expose us. But if there are negociations i will tell in chat simply "what do you prefer folks, have feature A and B or have app in fdroid?" sure if nothing from fdroid can ban us.

@b3pio answer is below

from telegraher.

nikitasius avatar nikitasius commented on August 27, 2024

@nikitasius this is great news! you may need to remove this from code for f-droid approval.

Google Firebase Analytics

*Google Firebase Analytics 2com.google.firebase.analytics.

Hi, yep. I wanna clean it a bit.

from telegraher.

nikitasius avatar nikitasius commented on August 27, 2024

@OshekharO well about your list:

  • Forward Without Quoting ( in Channels & Groups ) vanilla have it in 2 clicks
  • Delete From Cache ( in Channels & Groups ) vanilla have it in the menu when you select the chat
  • Mark all read debug menu have it "read all chats"
  • Save to cloud ( in Channels & Groups ) - INFO - please explain
  • Proxy from nekogram - INFO - which ones?
  • Copyright Infringement Blocked Bots, channels & groups Unlocked - TG have GEO bans and PLATFORM bans. GEO ban can be bypassed using another sim. Platform bans can be bypassed using another platform (all, android, ios and ms/ws for windows). Actually all works on debian. I can "emulate a linux", but to do it better need a lot of changed in a code. So faster to install a debian desktop client.
  • Option to delete all my messages from the group - number 4
  • Add "Go to first message" to three dot menu ( in Channels & Groups ) - added as 35, good idea
  • Inbuilt Updater ( Like Nekogram or mdgram ) - app will be updated by fdroid.
  • Add Amoled Theme As default i'm on IPS 😛
  • Unlimited Pinned option - added as 36, it will be client side
  • Custom audio bitrate in group Voip (64gram) - added as 37, good
  • [Redesign] Settings like mdgram i dont know mdgram. Own settings are on special page. Settings which extends basic functionality where the basic functionality.
  • More optimization ( overall ) means nothing :)
  • Add to favourites to three dot menu - INFO, what do you mean?
  • Voice Changer - already as 33
  • Manage inactive channels ( hulugram ) channels with no posts? well just scroll and leave.
  • Copy selection ( in Channels & Groups ) - INFO, need details
  • Add Independent Section For Bots List ( ime Messenger {botlist.net or botsarchive.com} ) - in vanilla you can filter the bots, but if you wanna add 3rd party API - no. It's data share&collection + dependancy from 3rd party service. Everyone can open a website, search and add a bot.
  • Keep the original file name when downloading files - added as 38 dnload and 39 for sending. Via checkbox, default is disabled.
  • Option to ignore Android-only content restrictions - already ignore it and the restriction array. if you mean "Button to enable content-sensitive" it;s addded as 40
  • Retract Vote ( mdgram & plus messenger ) - vanilla offer it

from telegraher.

 avatar commented on August 27, 2024

@AlbertEienstein, @IzzySoft 's repo would probably be a better option than maintaining his own repo for less work and more exposure for users to find this app. So either Izzys can be the repo it lives on or just as a stepping stone to main f-droid repo.

or Just A in-app updater so app can be downloaded via github releases and be updated automatically?

from telegraher.

b3pio avatar b3pio commented on August 27, 2024

@AlbertEienstein, @IzzySoft 's repo would probably be a better option than maintaining his own repo for less work and more exposure for users to find this app. So either Izzys can be the repo it lives on or just as a stepping stone to main f-droid repo.

or Just A in-app updater so app can be downloaded via github releases and be updated automatically?

If its published on Izzys repo then it keeps same dev keys as github release so it will then work either way you install. Its not signed with different keys like it would be in f-droid main repo.

from telegraher.

nikitasius avatar nikitasius commented on August 27, 2024

Concerning FCM

Hi, @IzzySoft recently i removed the FCM :)
picked some useful stuff from the foss one, include osmand maps.

from telegraher.

IzzySoft avatar IzzySoft commented on August 27, 2024

Hi @nikitasius – thanks for the heads-up! I just took a quick look: we're getting close. It's slightly beyond the size limit, but as pointed out I can close an eye on that. I just picked the armeabi build, but my library scanner still complains:

Offending libs:
---------------
* Android Vision (/com/google/android/gms/vision): NonFreeDep
* Google Mobile Services (/com/google/android/gms): NonFreeDep
* Firebase (/com/google/firebase): NonFreeNet,NonFreeDep
* ML Kit (/com/google/mlkit): NonFreeDep,Tracking

4 offenders.

Vision is probably pulled in by ML Kit. So are Firebase and GMS. All of them are proprietary/non-free. I'm not sure what you use them for, so I cannot name potential replacements. But Tracking with a personal/private messenger is not the best idea I'd say, so it would be good to get rid of ML Kit.

For the listing I'd also need some description and screenshots, ideally provided via Fastlane structures in the app's repo here (so you can easily adjust them whenever you feel the need, and my updater can take care to pull that automatically with the next release).

To make your donation links easier to discover, you could use a .github/FUNDING.yml (which my updater then would take care for as well). That's a Github standard, and yours would look like this:

custom: ['https://yoomoney.ru/to/410015481871381','https://paypal.me/nikitasius'] # up to 4 custom URLs

They seem to have no field for BTC or other crypto, and I currently cannot find the documentation. Other available fields would include:

github: # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
patreon: # Replace with a single Patreon username
open_collective: # Replace with a single Open Collective username
ko_fi: # Replace with a single Ko-fi username
tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
liberapay: # Replace with your Liberapay user name
issuehunt: # Replace with a single IssueHunt username
otechie: # Replace with a single Otechie username

from telegraher.

heller390 avatar heller390 commented on August 27, 2024

@nikitasius Is there the option to disable content filtering ?! I am unable to find it out.

from telegraher.

nikitasius avatar nikitasius commented on August 27, 2024

@heller390 you mean same like desktop have? i did not added it nor checked how does it work.
By default we ignore all what we can ignore. But i will take a look to this option.

Actually you can use tg desktop on linux to disable it.

from telegraher.

TeaqariaWTF avatar TeaqariaWTF commented on August 27, 2024

Can translation feature be added from owlGram? The Owlgram translation feature is very good. There is a vibration that occurs when switching between channels by swiping.Can this vibration feature be disabled in Nekox?

from telegraher.

TeaqariaWTF avatar TeaqariaWTF commented on August 27, 2024

Screenshot_20220604-072341_OwlGram
While saving a file to the device, we wait for the download to complete, just like this. Nekox also has a download manager, we don't have to wait on this screen while downloading

from telegraher.

TearsOfTheEarth avatar TearsOfTheEarth commented on August 27, 2024

Hi,

Cheers for the quick reaction removal.
A few suggestions if I may:

  • Option to completely hide large "unmute" button at the bottom that takes a lot of valueable space and only good for misclicks (option is still available under dots menu)
  • Option to hide (collapse to a single line all other unread occurencoes maybe with a reference to the first seen) similar messages that will save space and time seeing forwards and annoying ads that are crossposted to multiple channels. Though this might be challenging and resource consuming to implement as it probably requires to run through all unread messages and do full mesh comparison unless I miss a better algorithm. As an interim forwards from channel you are subscribed to might be collapsed this way.

from telegraher.

nikitasius avatar nikitasius commented on August 27, 2024

Hi, @IzzySoft , if you're still intrerresting, i will be glad to integrate with your repo. Normally i removed non-foss trash from client.
Actual betas aren't on github's CI/CD (cause if i will share them via github folks will think that it's release, even if i mentioned beta...), so here are the APKs, built on a server, you can analyze them: https://git.evildayz.com/Telegraher/betas/

The release will be in github releases via github actions.

Also some handy changes:

  • i wanna change readme/description, make it shorter (keeping legacy big text somewhere in a repo)
  • there are 4 apks, not 8. I removed sdk23 cause after cleaning permissions there are no differ now
  • new 8.8.x version will be incompatible with the oldones, so it will require a clean install
  • i will check if github will allow me to build all 4 apks in 1 release (before it was an issue due CI/CD limitations here)

Also, because new version will not work as an update for the old ones i wanna change app signature. I will make my own certificates for this. The purpose:

  • if someone will mod the app they can't install it over the actual app as they can do it now (the situation when someone got your phone, it's non-rooted and they simply install modded version to extract your data the easy way)

Also why i find good to use your repo:

  • apps are built on github or no matter which CI/CD where project are linked
  • folks can install apks from your repo via fdroid app or directly from the github

from telegraher.

nikitasius avatar nikitasius commented on August 27, 2024

image
Also it could be a bundle, just 1 apk with all architectures.
apk size is x2, but installed size +60Mb more.

from telegraher.

MasterKia avatar MasterKia commented on August 27, 2024
  • Option to hide third-party promotions or sponsorships in channels (advertisements by the channel owner).

How to detect if a message is advertisement?
If the message contains links or usernames to other Telegram channels then it's possibly an advertisement.

from telegraher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.