Add annotations/tags/baggage support to Spans about wingtips HOT 4 CLOSED

One note is that arbitrary baggage isnt always a part of tracing apis. For
example in baggage itself (the work from brown) tracing is a consumer of
baggage propagation layer. This is the same in finagle and grpc, for
example, who have their own context propagation layer independent of
tracing.

In other words, tags/annotatioms (dimensional lookup keys) are far more
common than baggage in a tracing api.

That said, definitely worth considering as it is convient for folks to be
able to stuff things like tokens into a distributed context and currently
the OT api defines a hook for that.

On 25 Aug 2016 02:18, "Nic Munroe" [email protected] wrote:

The Dapper paper and many distributed tracing impls have support for
arbitrary annotations/tags/baggage. Wingtips should follow suit to give
users more flexibility in what wingtips does for them, compatibility with
other impls, etc.

This may tie in with OpenTracing support.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#23, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD613rwa61fl_K6wrHnyXeQccIm6lc6ks5qjIrmgaJpZM4JsTMl
.

from wingtips.

Yeah this ticket is more of a placeholder for me to go investigate the current landscape and decide what I want to implement in wingtips for the near term. It will probably be along the simpler annotations line than full-throated baggage support. At least initially. Just a guess until I can carve out some time to investigate though.

from wingtips.

Tags are now supported after #74 and #78. Annotations and updating instrumentation to automatically tag/annotate (i.e. automatically tagging spans with http.method, http.path, http.status_code, error, etc) will come later.

from wingtips.

Annotations added in #84.

Wingtips version 0.16.0 added general tag support, 0.17.0 added auto-tagging for various server/client Wingtips instrumentations, and 0.18.0 added general annotation support.

Baggage has a lot of complexity and difficulty associated with it, and the benefit (and demand) doesn't seem worth it at this time. So for the purpose of this issue, we'll call it good after tags and annotations. If baggage needs to be revisited, it will be done in a separate issue.

from wingtips.