Git Product home page Git Product logo

Comments (37)

thisnameistoolo avatar thisnameistoolo commented on June 8, 2024 1

You mentioned sending you a message on discord, but I don't see any links to a discord channel or your private discord anywhere on this repository. I know this isn't the best place to write this message but I literally can't find your discord contact info anywhere.

from xivslothcombo.

armourine avatar armourine commented on June 8, 2024 1

I see that is unfortunate. Is it possible to replace Sleep with Ruin III instead?

from xivslothcombo.

Nik-Potokar avatar Nik-Potokar commented on June 8, 2024 1

So what I can do is move everything off ruin3 to one of the gemshine skills and that would free up ruin. il test it out tonight

from xivslothcombo.

Nik-Potokar avatar Nik-Potokar commented on June 8, 2024 1

Added same option but now on ruin1 so this completely frees up ruin3 and so far everything still functions like before

from xivslothcombo.

MarkusWo avatar MarkusWo commented on June 8, 2024 1

@k-kz It works! Thank You.

from xivslothcombo.

rushtothesun avatar rushtothesun commented on June 8, 2024

The only glaring thing I saw is that SimpleSummoner Option 1 needs to be changed. Spell Speed reduces Summon Bahamut's CD and with the current logic Searing Light will only be used when Bahamut is ready to be casted. With my current gear this means that when the 2nd Searing Light is coming up: Bahamut will be off CD while Searing is still on CD -> Bahamut will be used and Searing Light won't be used until the next Bahamut. I can imagine fights with deadtime will also be an issue. Such as having Phoenix ready and Searing Light up because of a transition. You'd lose an entire use of the buff there as well.

For Enkindle/Deathflare/Fester I'd say try to make it go off as close to the end of the gauge as you can to make sure all of that is being used while raid buffs are up. This might be tricky to do though because of Spell Speed again.

It's not easy to do an everything combo for Summoner because there's a bit of decision making on when to use the abilities which is also why a lot of the current combos for Summoner can be DPS losses depending on the circumstance.

from xivslothcombo.

Random-Stack-Random-Day avatar Random-Stack-Random-Day commented on June 8, 2024

I'll start going over it but one thing I noticed:

At a quick glance, I am fairly confident the Carbuncle Summon Feature will never be triggered as part of this.

Additionally, the Egi logic needs some work. Each succession tries to summon Rank 1 of the appropriate Egi. If you're spamming the button, this is actually fine (I still haven't figured out WHY that works).

To replicate, summon Bahamut and let it time out. You'll go to Summon Titan - But it'll be Rank 1. Don't hit anything for a second, and then when you go to hit it, it'll just be ignored as it isn't a valid key for you anymore. I think it'll need a daisy chain of if, or a function to respond which to summon based on level.

from xivslothcombo.

Nik-Potokar avatar Nik-Potokar commented on June 8, 2024

Thanks for all the feedback so far

@rushtothesun
About the spell speed issue i think id have to see the high sps rotation and go from there maybe add another option if you are a sps summoner so you can just toggle.

At a quick glance, I am fairly confident the Carbuncle Summon Feature will never be triggered as part of this.

Right it will only break if you die but will add a fix for this

Additionally, the Egi logic needs some work. Each succession tries to summon Rank 1 of the appropriate Egi. If you're spamming the button, this is actually fine (I still haven't figured out WHY that works).

Il be adding level checks/originalhook to solve the rank1 summon issues (Since i been testing on non 90 SMN)

@thisnameistoolo
Oh and i've added my discord above i guess i forgot to type it lol

from xivslothcombo.

SkyAurora avatar SkyAurora commented on June 8, 2024

Regarding the searing light with bahamut timing issue, maybe add another Ruin III in the opener after searing light. The opener on The Balance Discord actually has it like that. Ruin III > Searing > Ruin III > Bahamut

from xivslothcombo.

rushtothesun avatar rushtothesun commented on June 8, 2024

Regarding the searing light with bahamut timing issue, maybe add another Ruin III in the opener after searing light. The opener on The Balance Discord actually has it like that. Ruin III > Searing > Ruin III > Bahamut

The opener isn't the issue. The opener works fine.

from xivslothcombo.

armourine avatar armourine commented on June 8, 2024

Is it possible to change an unslotted skill to Ruin III so that I can manually delay bahamut by 1 cast to have alignment with searing light?

from xivslothcombo.

Iaotle avatar Iaotle commented on June 8, 2024

@armourine that's what the Ruin III mobility option does though I have no idea if it works for your use case.

from xivslothcombo.

armourine avatar armourine commented on June 8, 2024

i tried that option but i couldnt get a cast off, do you know what combinations of options it works with?

from xivslothcombo.

Iaotle avatar Iaotle commented on June 8, 2024

Like it says on the option it will probably break most options with R4. I only have Egi Attacks/Mountain Buster/Fester/Painflare/Reminder features enabled and it works perfectly.

from xivslothcombo.

DurzoThorn avatar DurzoThorn commented on June 8, 2024

I see that is unfortunate. Is it possible to replace Sleep with Ruin III instead?

Can agree this would be an awesome addition as for some fights I need to delay bahamut by two or three gcds so searing lines up with mechanics for group damage to beat enrage check p4s part 2 for example. Only option for me currently is to disable some features or try to rely on ruin 3 mobility feature but it seemed to only work for 1 cast sometimes not sure if it is registering on a 1 charge type system since it's replacing ruin 4.

from xivslothcombo.

Iaotle avatar Iaotle commented on June 8, 2024

@armourine @DurzoThorn the issue is that if you have R3 combos they will replace Ruin III. So if you replace Sleep with R3, you're going to replace R3 with your egi skills etc.

from xivslothcombo.

DurzoThorn avatar DurzoThorn commented on June 8, 2024

You rock I will check it out tomorrow after patch reset!

Edit: It works like a charm now I can min max on the encounters that require it and lazy brain the ones that don't. Thanks!!

from xivslothcombo.

klevox avatar klevox commented on June 8, 2024

I need help Nothing I click for SMN works. Other jobs work fine is there a guide to setting up SMN? One button would be nice.

from xivslothcombo.

Nik-Potokar avatar Nik-Potokar commented on June 8, 2024

I need help Nothing I click for SMN works. Other jobs work fine is there a guide to setting up SMN? One button would be nice.

@klevox As in you cant enable the features ? or when you enable the actual skills wont change?

from xivslothcombo.

Iaotle avatar Iaotle commented on June 8, 2024

@klevox don't worry everything works.

See how that isn't helpful? Provide us with a list of features you have enabled.

from xivslothcombo.

klevox avatar klevox commented on June 8, 2024

@klevox don't worry everything works.

See how that isn't helpful? Provide us with a list of features you have enabled.

Sorry that was a wrong post. It was about the dalamud not working. On patch day it worked after the update.

from xivslothcombo.

klevox avatar klevox commented on June 8, 2024

I need help Nothing I click for SMN works. Other jobs work fine is there a guide to setting up SMN? One button would be nice.

@klevox As in you cant enable the features ? or when you enable the actual skills wont change?

When I try to enable just one feature for testing. Skills do not change, like Carbuncle reminder (enabled) nothing happens. The one button feature enabled nothing else. There is no change to the skill. I have tried every combination of features no skill change at all.

from xivslothcombo.

Nik-Potokar avatar Nik-Potokar commented on June 8, 2024

@klevox Make sure you have Single Target Feature enabled ether Ruin1/Ruin3 and then you need to have a correct skill on your hotbar ruin1/ruin3 (Note: Upgraded skill wont work it has to be directly from your skill page so i recommend just dragging the corresponding skill on hotbar)

If you still cant get it to work you can add me on discord "Aki#9251" so i can help you directly

from xivslothcombo.

klevox avatar klevox commented on June 8, 2024

@klevox Make sure you have Single Target Feature enabled ether Ruin1/Ruin3 and then you need to have a correct skill on your hotbar ruin1/ruin3 (Note: Upgraded skill wont work it has to be directly from your skill page so i recommend just dragging the corresponding skill on hotbar)

If you still cant get it to work you can add me on discord "Aki#9251" so i can help you directly

Thank you I will try that now. :)

from xivslothcombo.

Nik-Potokar avatar Nik-Potokar commented on June 8, 2024

@klevox Let me know if that fixed it. If not im available to help on discord

Edit: Issue has been resolved

from xivslothcombo.

DurzoThorn avatar DurzoThorn commented on June 8, 2024

Alright so next big feature request that I think should be possible. Can we add energy drain and fester to the main combo and structure it so energy drain is used off cool down as long as no fester stacks remain and fester only shows while buffed by searing light? This should give us the maximum potency out of our ogcds without any real brain power. Only times this wouldn't be ideal is if we are holding searing for a delayed buff window but should just be able to use fester like normal off the main combo button in those situations. Assuming standard GCD priority protections are in place for astral impulse it shouldn't mess with pot usage either after demi summon for 6 min windows.

from xivslothcombo.

Nik-Potokar avatar Nik-Potokar commented on June 8, 2024

@DurzoThorn Thats what "Lazy Fester Feature" already kinda does. It uses ED/fester during bahamut phase and only uses ED and then saves festers for bahamut phase again.

from xivslothcombo.

DurzoThorn avatar DurzoThorn commented on June 8, 2024

@DurzoThorn Thats what "Lazy Fester Feature" already kinda does. It uses ED/fester during bahamut phase and only uses ED and then saves festers for bahamut phase again.

Gotcha the way I read that was it would use festers between gcds in a non optimal method I will toggle it on and let you know how it feels, thanks for the reply.

from xivslothcombo.

DurzoThorn avatar DurzoThorn commented on June 8, 2024

@Nik-Potokar So I have been playing with the Lazy Fester Feature and my only real issue is that depending on when Energy drain comes off cooldown there can be an occurrence of clipping astral impulse. This is due to the Energy drain coming up in the second half of the weave window and then transitioning to Fester for a double weave that is not actually able to fit thus clipping the next GCD Astral. It might be specific to me since I use XiV Alexander and a turbo mouse button to spam the key every .1 seconds but I was curious if Astral Impulse could lock in as the priority icon 500ms ish before the gcd rolls again to avoid clipping. I would be happy to demonstrate the issue if it isnt clear from the text. Thanks!

from xivslothcombo.

Iaotle avatar Iaotle commented on June 8, 2024

@DurzoThorn if you want to avoid clipping issues entirely you shouldn't use weave combos and should just weave manually.

from xivslothcombo.

Sylvansnake avatar Sylvansnake commented on June 8, 2024

So what I can do is move everything off ruin3 to one of the gemshine skills and that would free up ruin. il test it out tonight

This is probably the best solution. Just add both combo chains to Gemshine and Precious Brilliance for simplicity. Then people can still use standalone Ruin/Outburst/Tri-disaster spells as they see fit.

from xivslothcombo.

lucktacular avatar lucktacular commented on June 8, 2024

Hi Aki! I love the plugin. Thanks so much for your work on it :)

I noticed that a recent update has changed the single target rotation to no longer enter the Bahamut phase of the rotation (the AoE one still does). It will just sit there casting Ruin III until I hit the AoE button once to summon Bahamut, then go back to the single target rotation where it goes back to working normally.

Also when it's doing the phoenix portion of the rotation, it will use Energy Drain and generate the aetherflow stacks, but it won't spend them on Fester or Painflare (on the ST and AoE rotations respectively). It spends the aetherflow stacks normally during the Bahamut summon though.

I was wondering if I was doing something wrong, or if any of these changes were deliberate, or if it was simply a bug.

EDIT: Issue resolved over a short Discord chat. I was being a dumb with the tick box settings, and also I didn't realize Fester and Painflare shouldn't cast during the phoenix summon.

from xivslothcombo.

Nik-Potokar avatar Nik-Potokar commented on June 8, 2024

Hi Aki! I love the plugin. Thanks so much for your work on it :)

I noticed that a recent update has changed the single target rotation to no longer enter the Bahamut phase of the rotation (the AoE one still does). It will just sit there casting Ruin III until I hit the AoE button once to summon Bahamut, then go back to the single target rotation where it goes back to working normally.

Also when it's doing the phoenix portion of the rotation, it will use Energy Drain and generate the aetherflow stacks, but it won't spend them on Fester or Painflare (on the ST and AoE rotations respectively). It spends the aetherflow stacks normally during the Bahamut summon though.

I was wondering if I was doing something wrong, or if any of these changes were deliberate, or if it was simply a bug.

Make sure you have the correct Option ticked since I've added a choice in between everything on ruin1(this is better for optimization) or ruin3 that you have a correct skill slotted in the hotbar(upgraded skill won't work you have to drag ether ruin1 or ruin3 from skill book onto your hotbar depending on the option you got ticked)

If are still having issue setting it up you can dm me on discord or post a picture of what options you got enabled here and il help you out further.

from xivslothcombo.

Iaotle avatar Iaotle commented on June 8, 2024

Should be working as intended now.

from xivslothcombo.

MarkusWo avatar MarkusWo commented on June 8, 2024

If are still having issue setting it up you can dm me on discord or post a picture of what options you got enabled here and il help you out further.

Unfortunately, I have the same problem as lucktacular had. With my settings, Ruin III just stays Ruin III and never changes to summon Bahamut. I will have to hit the AoE button once to summon Bahamut. Since lucktacular didn't really say how they fixed this I just been looking through all options over and over again to see where there might be a choice. I cannot find the problem, sadly. It doesn't seem to make a difference whether I use "Enable Single Target (Ruin1)" Or RuinIII in the beginning.

I've attached my settings. I have almost everything on since it all seems cool. Thank You if you can look at it.

P.S. lucktacular mentioned discord, do you have your own discord server?

ffxiv_31032022_004454_159
ffxiv_31032022_004500_458

from xivslothcombo.

k-kz avatar k-kz commented on June 8, 2024

@MarkusWo discord server link is on the readme, main page :]

you need to check the "Demi Reminder Feature" - iirc the description is inaccurate and you should be using it. Try with that turned on and let me know if it works

from xivslothcombo.

k-kz avatar k-kz commented on June 8, 2024

@MarkusWo will get the descriptions fixed eventually, bugs first! o/

from xivslothcombo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.