Make CMake options consistent about libzip HOT 3 OPEN

Do you have a pointer to documentation about using subprojects with CMake and best practices for variables in that case?
This change is quite invasive since all packagers and users setting options will need to update their variables, and we can't add backward compatibility since this would defeat the point of the change.
(At least BUILD_SHARED_LIBS should consider the project-wide setting without a LIBZIP_ prefix.)

from libzip.

Do you have a pointer to documentation about using subprojects with CMake and best practices for variables in that case? This change is quite invasive since all packagers and users setting options will need to update their variables, and we can't add backward compatibility since this would defeat the point of the change. (At least BUILD_SHARED_LIBS should consider the project-wide setting without a LIBZIP_ prefix.)

https://discourse.cmake.org/t/best-practices-for-option-naming/2039 for an example, a lot of libraries do that. And yeah you are right about BUILD_SHARED_LIBS, it actually affects add_library behavior so it should be kept as is (I reverted that in the PR). The issue with needing to change the options when packaging is indeed kind of annoying one, I am not really sure what would be the best solution for that.

from libzip.