Git Product home page Git Product logo

Comments (3)

bniels707 avatar bniels707 commented on May 27, 2024

In my experimentation, it is because filter parameters are apparently expected to be passed directly instead of via the filter_parameters query arg.

E.g.: date$gte=2024-03-04 works, filter_parameters=date$gte=2024-03-04 doesn't. I still haven't figured out how to pass multiple filter parameters to set a range, date$gte=2024-03-04&date$lte=2024-03-05 doesn't work.

If I can figure this out, I might look into why the Swagger output is wrong.

from cgm-remote-monitor.

bniels707 avatar bniels707 commented on May 27, 2024

I opened a MR (#8252) to fix range queries for a single field.

Unfortunately I don't think the current implementation of filter_parameters in APIv3 is OpenAPI / Swagger compatible so I can't figure out a way to fix it. It can made better by changing the type of filter_parameters to a string array, with style set to form and explode set to true. Unfortunately it still prepends filter_parameters to every parameter so the filters aren't actually applied by the API endpoint.

I'll have to see if I can come up with a way to handle the API as defined in the Swagger definition without breaking the old behavior.

from cgm-remote-monitor.

bniels707 avatar bniels707 commented on May 27, 2024

I have opened another MR (#8253) to support filter parameters passed via the filter_parameters argument to match the behavior described in the current Swagger definition, as well as an update to the Swagger definition which makes it explicit that multiple filter parameters can be passed.

from cgm-remote-monitor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.