Git Product home page Git Product logo

Comments (8)

niemasd avatar niemasd commented on August 27, 2024

What version are you using? I just ran it 20 times and got sequences each time (both error-free and error-prone)

from favites.

smazrouee avatar smazrouee commented on August 27, 2024

This is the problem which makes it hard for me to trace and find the reason. I also ran the same Config file 10-20 times and only sometimes it doesn't generate sequences, while the config is exactly the same (except the out_dir).

I have more than one example with this problem, but here couldn't upload. So I copied the content of one file. This run is the latest version from Feb 28th btw (before you incorporate -u)

from favites.

niemasd avatar niemasd commented on August 27, 2024

I ran it 150 times just now, and it succeeded and produced sequences every time. Perhaps try using the most recent versioned FAVITES Docker image (via -u) and see if it still happens?

from favites.

smazrouee avatar smazrouee commented on August 27, 2024

(probably) because of stochasticity incorporated in the software you are unable to get the same exact results yet (or the chance of bumping to the same problem is next to zero). Sounds to me it's hard to trace back and see what was the reason, which is understandable... Maybe later (after you implemented reproducibility) you can come back and look at this

from favites.

niemasd avatar niemasd commented on August 27, 2024

(probably) because of stochasticity incorporated in the software you are unable to get the same exact results yet (or the chance of bumping to the same problem is next to zero)

I would think this is the case, but you earlier said the following:

I also ran the same Config file 10-20 times and only sometimes it doesn't generate sequences

This implies you are running into this multiple times in only 10-20 executions, whereas I ran it 150 times and didn't run into it at all. Even assuming you only saw it once out of 20 times (so roughly Geometric distribution with p = 0.05), me not observing it after 150 tries has probability (1-0.5)^150 = 0.0005. Thus, I don't think it's likely that stochasticity is the reason why I'm not able to reproduce the issue

from favites.

smirarab avatar smirarab commented on August 27, 2024

from favites.

niemasd avatar niemasd commented on August 27, 2024

I just ran it 150 times using the 1.0.3 Docker image on Calab, and I had the same result (sequences exist each time). Here is how I'm running it:

r=1; while : ; do echo $r && ((r++)) && rm -rf test && ~/bin/FAVITES/run_favites_docker.py -c test.json -o test && ls test/error_free_files/sequence_data.fasta > /dev/null || break; done

Basically, I have an infinite loop (while : ; do ... ; done) where I run FAVITES via run_favites_docker.py (with the 1.0.3 image in my environment) on the config file (I'm having it output to a directory called test for simplicity), and I attempt to ls the file test/error_free_files/sequence_data.fasta. If this succeeds (i.e., the file exists), the logical OR (||) does not enter the second condition (break), so the loop continues. If this fails (i.e., the file does not exist), the first condition of the logical OR fails, so it enters the second condition (break) and terminates the loop. Thus, as long as the loop doesn't terminate, FAVITES is running successfully. I just arbitrarily killed it once I hit 150.

from favites.

niemasd avatar niemasd commented on August 27, 2024

I'll close this for now because I'm unable to reproduce the issue using the latest versioned Docker image (1.0.3), so if it was a bug in FAVITES, I assume it's been fixed

from favites.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.